Bug 1428284 - [RFE] VMware VM Add Disk be able to specify controller type
Summary: [RFE] VMware VM Add Disk be able to specify controller type
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Adam Grare
QA Contact: Alex Newman
URL:
Whiteboard:
Depends On:
Blocks: 1480786
TreeView+ depends on / blocked
 
Reported: 2017-03-02 08:40 UTC by Gellert Kis
Modified: 2020-12-14 08:16 UTC (History)
10 users (show)

Fixed In Version: 5.9.0.5
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-03-01 13:10:28 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2018:0380 0 normal SHIPPED_LIVE Moderate: Red Hat CloudForms security, bug fix, and enhancement update 2018-03-01 18:37:12 UTC

Comment 3 CFME Bot 2017-10-05 15:58:16 UTC
New commit detected on ManageIQ/manageiq-providers-vmware/master:
https://github.com/ManageIQ/manageiq-providers-vmware/commit/bf9e15582c19e34ae38b91fc9fda2e36c319011b

commit bf9e15582c19e34ae38b91fc9fda2e36c319011b
Author:     Adam Grare <agrare>
AuthorDate: Mon Oct 2 14:31:33 2017 -0400
Commit:     Adam Grare <agrare>
CommitDate: Mon Oct 2 14:31:33 2017 -0400

    Allow type of controller to be passed in disk opts
    
    When adding a new disk when a new controller is needed we currently try
    to use the same type of controller that is already on the VM or we have
    a default that we use.  If a user wants to specify specifically what
    type of controller they want there is no way to do that.  This adds the
    option to the disk options hash to have the new scsi controller type
    explicitly defined by the user.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1428284

 .../providers/vmware/infra_manager/vm/reconfigure.rb   |  9 ++++++---
 .../vmware/infra_manager/vm/reconfigure_spec.rb        | 18 +++++++++++++++---
 2 files changed, 21 insertions(+), 6 deletions(-)

Comment 4 Dan Clarizio 2017-10-19 15:55:18 UTC
UI Pivotal story here: https://www.pivotaltracker.com/story/show/152116440

Comment 5 Adam Grare 2017-10-19 16:00:01 UTC
Valid options are:
VirtualLsiLogicController, ParaVirtualSCSIController, VirtualBusLogicController, and VirtualLsiLogicSASController

VirtualLsiLogicController should be the default.

Comment 8 Alex Newman 2017-11-21 20:23:14 UTC
In testing the new disk was added to the existing controller no matter what type was selected.

Comment 9 Adam Grare 2017-11-21 20:24:47 UTC
This only applies to the case when a new controller needs to be added so the 1st, 16th, etc.. disk

Comment 12 Alex Newman 2017-11-21 20:35:02 UTC
Thanks Adam.

Comment 15 errata-xmlrpc 2018-03-01 13:10:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380


Note You need to log in before you can comment on or make changes to this bug.