Spec URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-annotations.spec SRPM URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-annotations-30.0.3-1.fc25.src.rpm Description: This package provides the emoji annotation file by language in CLDR. Fedora Account System Username: fujiwara
Updated: Spec URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-annotations.spec SRPM URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-annotations-30.0.3-1.2.fc25.src.rpm
Suggestions: 1) License should be "LGPLv2+ and Unicode" with comment above to license tag as "# Annotation files are in Unicode license" 2) Package does not look compiling anything, why not make it noarch by adding ExclusiveArch: noarch We have similar pkgconfig file packaging in m17n-db-devel noarch package. 3) No known owner of /usr/share/cldr, /usr/share/cldr/common I suggest upstream changes like install these files in /usr/share/unicode/cldr. We already have unicode-ucd package which installs files in /usr/share/unicode/ucd
Updated. Spec URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-emoji-annotation.spec SRPM URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-emoji-annotation-30.0.3_2-1.fc25.src.rpm
Updated. Spec URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-emoji-annotation.spec SRPM URL: https://fujiwara.fedorapeople.org/cldr-annotations/cldr-emoji-annotation-30.0.3_2-2.fc25.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Small thing to fix 1) cldr-emoji-annotation.noarch: W: incoherent-version-in-changelog 30.0.3-2_2 ['30.0.3_2-2.fc26', '30.0.3_2-2'] => fix the version string here ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "FSF Unlimited GPL", "FSF All Permissive", "FSF Unlimited", "Unknown or generated". 104 files have unknown license. Detailed output of licensecheck in /home/parag/1428287-cldr-emoji-annotation/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/unicode(unicode- ucd) ==> This is Okay as both are not dependent on each other [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cldr-emoji-annotation-30.0.3_2-2.fc26.noarch.rpm cldr-emoji-annotation-devel-30.0.3_2-2.fc26.noarch.rpm cldr-emoji-annotation-30.0.3_2-2.fc26.src.rpm cldr-emoji-annotation.noarch: W: incoherent-version-in-changelog 30.0.3-2_2 ['30.0.3_2-2.fc26', '30.0.3_2-2'] cldr-emoji-annotation-devel.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure cldr-emoji-annotation-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory cldr-emoji-annotation.noarch: W: incoherent-version-in-changelog 30.0.3-2_2 ['30.0.3_2-2.fc26', '30.0.3_2-2'] cldr-emoji-annotation-devel.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure cldr-emoji-annotation-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- cldr-emoji-annotation (rpmlib, GLIBC filtered): cldr-emoji-annotation-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cldr-emoji-annotation pkgconfig Provides -------- cldr-emoji-annotation: cldr-emoji-annotation cldr-emoji-annotation-devel: cldr-emoji-annotation-devel pkgconfig(cldr-emoji-annotation) Source checksums ---------------- https://github.com/fujiwarat/cldr-emoji-annotation/releases/download/30.0.3_2/cldr-emoji-annotation-30.0.3_2.tar.gz : CHECKSUM(SHA256) this package : 8504a17aca042cd48590839a782c7d6c987c6d35982b487557effcbe5ea4e84b CHECKSUM(SHA256) upstream package : 8504a17aca042cd48590839a782c7d6c987c6d35982b487557effcbe5ea4e84b Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1428287 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/cldr-emoji-annotation
cldr-emoji-annotation-30.0.3_2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f90649a333
cldr-emoji-annotation-30.0.3_2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f90649a333
cldr-emoji-annotation-30.0.3_2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.