Hide Forgot
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-bkaradzic-go-lz4.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-bkaradzic-go-lz4-1.0.0-1.fc25.src.rpm Description: Port of LZ4 lossless compression algorithm to Go Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18138835 PS: The .spec file was generated by gofed, but modified to use the stable release of the go library in question instead of git master. Also, I had to add the "testdata" directory to make the tests work - this includes a text file from Project Gutenberg (pg1661.txt). I am not sure if that is acceptable or not. According to my research, the text in question (The Adventures of Sherlock Holmes, by Arthur Conan Doyle) is in the Public Domain in the US and in the EU [1], so it should be alright ... If not, I will disable the unit tests for this package and not ship the text with the built packages. [1]: https://en.wikisource.org/wiki/The_Adventures_of_Sherlock_Holmes
Just a nit. I would suggest to move %{gopath}/src/%{import_path}/testdata line form %files unit-test-devel into %install section as echo "%%{gopath}/src/%%{import_path}/testdata" >> unit-test-devel.file-list right under cp -pvr testdata %{buildroot}/%{gopath}/src/%{import_path}/ So the directory ownership is as close to the command it created it as possible. Wrt. book copyrights, Tom, can you take a look at it?
Good point, I moved the directory entry to the unit-test-devel.file-list, just like you suggested.
That work is clearly and unambiguously in the Public Domain in the US as a result of "Klinger v Conan Doyle Estate, Ltd.": http://law.justia.com/cases/federal/appellate-courts/ca7/14-1128/14-1128-2014-06-16.html Note: Not _all_ of the Sherlock Holmes books are out of copyright, but this one is.
jchaloup, can you please look at this again, now that the copyright issue is out of the way?
Thanks Tom. Approved.
Thanks for the review! Pkgdb request is sent. If you (jchaloup) need some packages reviewed at any point in time, just ping me - because it's been really nice to get those syncthing deps into fedora so quickly!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-bkaradzic-go-lz4
golang-github-bkaradzic-go-lz4-1.0.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-99747f14b8
golang-github-bkaradzic-go-lz4-1.0.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-71bcfd28d9
golang-github-bkaradzic-go-lz4-1.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e516c276d
golang-github-bkaradzic-go-lz4-1.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e516c276d
golang-github-bkaradzic-go-lz4-1.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-71bcfd28d9
golang-github-bkaradzic-go-lz4-1.0.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-99747f14b8
golang-github-bkaradzic-go-lz4-1.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-bkaradzic-go-lz4-1.0.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-bkaradzic-go-lz4-1.0.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.