Bug 1428521 - Review Request: golang-github-calmh-xdr - XDR enc/decoder for Go
Summary: Review Request: golang-github-calmh-xdr - XDR enc/decoder for Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1427634
TreeView+ depends on / blocked
 
Reported: 2017-03-02 18:12 UTC by Fabio Valentini
Modified: 2017-03-15 17:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-14 17:21:54 UTC
Type: ---
Embargoed:
jchaloup: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2017-03-02 18:12:13 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-xdr.spec

SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc25.src.rpm

Description: XDR enc/decoder for Go

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18139747

PS: The .spec file was generated by gofed, but the version set to 2.0.0 (the latest release) instead of 0, since there _are_ releases (but still, git master is packaged since it has bug fixes atop 2.0.0). All tests pass on all arches (see the successful koji scratch build).

Comment 1 Jan Chaloupka 2017-03-03 12:46:53 UTC
I always keep the
Source0:        https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz
in a form of
Source0:        https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz

You will always get the same tarball as long as the commit corresponds to version. At the same time it is easier to update to non-versioned commit.

Not a blocker thought.

Comment 2 Fabio Valentini 2017-03-03 13:25:09 UTC
Thanks, but I think this is a copy-paste-error, because the Source0 tag in this .spec is already in the form you suggested :)

I just submitted the pkgdb request.

Comment 3 Jan Chaloupka 2017-03-03 14:00:25 UTC
Yeah :) Got confused by the comment you are changing the version.

Comment 4 Gwyn Ciesla 2017-03-06 14:34:46 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-calmh-xdr

Comment 5 Fedora Update System 2017-03-06 17:06:43 UTC
golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-087794938a

Comment 6 Fedora Update System 2017-03-06 17:07:57 UTC
golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-40b4386e96

Comment 7 Fedora Update System 2017-03-07 01:51:08 UTC
golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-087794938a

Comment 8 Fedora Update System 2017-03-07 17:53:39 UTC
golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-40b4386e96

Comment 9 Fedora Update System 2017-03-14 17:21:54 UTC
golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-03-15 17:52:37 UTC
golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.