criu is currently built only for aarch64, armv7hl, ppc64le and x86_64. It is not built for i686 or ppc64. However, docker recently grew a dep on criu, meaning docker now cannot be installed on i686 or ppc64. This is currently blocking most image builds for i686, as the installer environment pulls in the docker-anaconda-addon package, which depends on docker. We could skip that package on the affected arches if necessary, I think, but I figured it'd be a good first step to see if the criu dependency is really necessary on arches where criu is not available.
is this enough? ``` diff --git a/docker.spec b/docker.spec index b4d4b20..5191a0a 100644 --- a/docker.spec +++ b/docker.spec @@ -144,7 +144,9 @@ Requires: device-mapper-libs >= 1.02.90-1 Requires: skopeo-containers Requires: gnupg +%ifnarch i686 ppc64 Requires: criu +%endif # BZ#1399098 Requires: python-rhsm-certificates ```
Well, probably. But if you can do that, why is it 'Requires:' on other arches? What's the actual reason for the dependency?
(In reply to Adam Williamson from comment #2) > Well, probably. But if you can do that, why is it 'Requires:' on other > arches? What's the actual reason for the dependency? criu is needed for containers checkpoint & restore via "docker checkpoint" and "docker restore". If criu isn't available on those arches I believe it's save to skip the Requires as the commands will nicely tell you criu isn't installed.
Which means we should change this to an optional requires correct?
isn't https://bugzilla.redhat.com/show_bug.cgi?id=1428638#c1 sufficient?
It's sufficient to fix this problem, but it's worth considering whether the Requires: is correct in the first place, or if it would be better off as a Recommends: . If it was changed to a Recommends: , I believe that would also solve this problem.
Given checkpoint&restore is an experimental docker feature, and we don't enable experimental in Fedora at all, I'm moving the Requires: to a Recommends: now. Dan, wdyt?
Yes makes sense. Probably don't need it at all if the version of docker we ship does not cupport CRIU.
changed to a Recommends in https://koji.fedoraproject.org/koji/taskinfo?taskID=18486056 let me know if that works out well
Can you please also fix this for F26?
proposing as a freeze exception for Alpha as it prevents us making all 32 bit x86 and ppc64 deliverables
Discussed during the 2017-03-27 blocker review meeting: [1] The decision was made to classify this bug as an AcceptedFreezeException was made as it would be nice to have this fixed in Alpha release. [1] https://meetbot.fedoraproject.org/fedora-blocker-review/2017-03-27/f26-blocker-review.2017-03-27-16.01.txt
docker-1.13.1-5.git5be1549.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6e04c798f1
docker-1.13.1-5.git5be1549.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.