Spec URL: http://svn.cern.ch/guest/lcgdm/xrdhttpvoms/tags/v0.2.3/dist/xrdhttpvoms.spec SRPM URL: http://grid-deployment.web.cern.ch/grid-deployment/dms/lcgdm/repos/release-candidate/el6/x86_64/xrdhttpvoms-0.2.4-1.20170303.1517rc.el6.src.rpm Description: This package provides the VOMS security extractor plugin for XrdHTTP. Givena working setup of XrdHTTP, this library will be able to extract the VOMS information from the certificate presented by the client. The extracted information will be available for other plugins to apply authorization rules. Fedora Account System Username: andreamanzi
correct urls: SPEC URL: https://svnweb.cern.ch/trac/lcgdm/browser/xrdhttpvoms/tags/v0.2.4/dist/xrdhttpvoms.spec SRPM URL: https://grid-deployment.web.cern.ch/grid-deployment/dms/lcgdm/repos/el6/x86_64/xrdhttpvoms-0.2.4-1.20170310.0948.el6.src.rpm
sorry ..correct spec URL http://svn.cern.ch/guest/lcgdm/xrdhttpvoms/tags/v0.2.4/dist/xrdhttpvoms.spec
I will take this review.
Some initial comments: 1. rpmlint output is not clean: Rpmlint ------- Checking: xrdhttpvoms-0.2.4-1.el7.centos.x86_64.rpm xrdhttpvoms-0.2.4-1.el7.centos.src.rpm xrdhttpvoms.x86_64: W: summary-ended-with-dot C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: E: summary-too-long C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: W: incoherent-version-in-changelog 0.2.0-2 ['0.2.4-1.el7.centos', '0.2.4-1.centos'] xrdhttpvoms.x86_64: E: library-without-ldconfig-postin /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: E: library-without-ldconfig-postun /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libXrdHttpVOMS-4.so xrdhttpvoms.src: W: summary-ended-with-dot C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.src: E: summary-too-long C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line 1) xrdhttpvoms.src: W: invalid-url Source0: xrdhttpvoms-0.2.4.tar.gz Rpmlint (installed packages) ---------------------------- xrdhttpvoms.x86_64: W: summary-ended-with-dot C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: E: summary-too-long C Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates. xrdhttpvoms.x86_64: W: incoherent-version-in-changelog 0.2.0-2 ['0.2.4-1.el7.centos', '0.2.4-1.centos'] xrdhttpvoms.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 /lib64/libm.so.6 xrdhttpvoms.x86_64: E: library-without-ldconfig-postin /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: E: library-without-ldconfig-postun /usr/lib64/libXrdHttpVOMS-4.so.0.2.4 xrdhttpvoms.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libXrdHttpVOMS-4.so xrdhttpvoms-debuginfo.x86_64: W: only-non-binary-in-usr-lib For sure we need to fix the errors: - summary should not exceed 79 characters - post and postun are obligatory: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig It would be also good to fix the warnings: - incoherent-version-in-changelog - devel-file-in-non-devel-package (either add a devel package or don't install .so) - unused-direct-shlib-dependency - and the trivial staff 2. License file LICENSE is marked as %doc instead of %license 3. CMake build type should be 'RelWithDebInfo' 4. The 'rm -rf %{buildroot}' statement in %install and the %clean section are unnecessary (unless you are planing to release for EPEL5) 5. The %defattr should only be used when setting a non-default value, here it is unnecessary (unless you are planing to release for EPEL5) 6. The Buildroot tag should not be used (unless you are planing to release for EPEL5)
Hi Michal, thank you very much for the prompt review. I applied all the fixes that were possible, here are the new links SPEC URL: https://svnweb.cern.ch/trac/lcgdm/browser/xrdhttpvoms/tags/v0.2.4b/dist/xrdhttpvoms.spec SRPM URL: https://grid-deployment.web.cern.ch/grid-deployment/dms/lcgdm/repos/release-candidate/el6/x86_64/xrdhttpvoms-0.2.4-2.20170315.1355rc.el6.src.rpm Please let me know f
Thanks for addressing my comments! Package Review ============== Legend: [x] = Pass, [-] = Not applicable ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: %build honors applicable compiler flags. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [-]: Package contains desktop file if it is a GUI application. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: The debuginfo package(s) has been tested with rpmlist. [x]: All installed packages have been tested with rpmlint. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/xrdhttpvoms