Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/master/php/phpunit/php-sebastian-comparator2/php-sebastian-comparator2.spec SRPM URL: http://rpms.remirepo.net/SRPMS/php-sebastian-comparator2-2.0.0-1.remi.src.rpm Description: This component provides the functionality to compare PHP values for equality. Fedora Account System Username: remi -- for phpunit6
Spec: https://git.remirepo.net/cgit/rpms/php/sebastian/php-sebastian-comparator2.git/plain/php-sebastian-comparator2.spec Srpm: http://rpms.remirepo.net/SRPMS/php-sebastian-comparator2-2.0.0-1.remi.src.rpm
Created attachment 1271290 [details] review.txt
fedora-review marked two things to fix in the must section, but I disagree that they are strict requirements so I'm passing the review. Suggestions to improve the spec file: [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-sebastian-comparator2
php-sebastian-comparator2-2.0.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-608c81542b
php-sebastian-comparator2-2.0.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-608c81542b
php-sebastian-comparator2-2.0.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.