Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/3b4caf51923362cd82b090808f889c5ce5dffa22/Fedora/dataagregator.spec SRPM URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/3b4caf51923362cd82b090808f889c5ce5dffa22/Fedora/dataagregator-0.9.2-2.fc25.src.rpm Description: Data agregation utility is a program for extracting information from multiple remote servers via ssh simultaneously. Your can collect any remote server ssh output. Features: Simple to use. If you know about json, ssh and bash, your know how to use it! It provides simultaneous aggregating from multiple servers and simultaneous executing multiple bash commands on each server. Each standard output from bash command is writing to the separate file. Fedora Account System Username: milovidov
Spec URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/86613ee468ca944bcd71aceb6d91e0ca952bd761/Fedora/dataagregator.spec SRPM URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/86613ee468ca944bcd71aceb6d91e0ca952bd761/Fedora/dataagregator-0.9.2-3.fc25.src.rpm Updated urls after changes in spec file.
Spec URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/7bd2b92658f47d3881c7966bfd863e6744b89362/Fedora/dataagregator.spec SRPM URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/7bd2b92658f47d3881c7966bfd863e6744b89362/Fedora/dataagregator-0.9.2-4.fc25.src.rpm Updated urls after changes in spec file.
Hello, I'm not yet a packager, so this is an unofficial review. Package Review ============== REVIEW: + OK - NA X ISSUE + Package meets naming and packaging guidelines. + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches ^^ I'm not sure about license files. I haven't seen information about MIT, GPLv3+ or BSD. + License file included in package + Spec in American English + Spec is legible. + Sources match upstream sha256sum: $ sha256sum 0.9.2.tar.gz rpmbuild/SOURCES/dataagregator-0.9.2.tar.gz 2df8316e0b9eab76425f83c38a79f9f6a341767803ca268fe571ed2c8fc1871f 0.9.2.tar.gz 2df8316e0b9eab76425f83c38a79f9f6a341767803ca268fe571ed2c8fc1871f rpmbuild/SOURCES/dataagregator-0.9.2.tar.gz X Package needs ExcludeArch ^^ I think you may add exclude arch, as you can see in the following link. https://koji.fedoraproject.org/koji/taskinfo?taskID=18275674 + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. $ rpmls /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.2-4.fc27.x86_64.rpm -rwxr-xr-x /usr/bin/DataAgregator drwxr-xr-x /usr/share/doc/dataagregator -rw-r--r-- /usr/share/doc/dataagregator/README.md drwxr-xr-x /usr/share/licenses/dataagregator -rw-r--r-- /usr/share/licenses/dataagregator/COPYING -rw-r--r-- /usr/share/licenses/dataagregator/license.txt + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. X Rpmlint output: $ rpmlint rpmbuild/SPECS/dataagregator.spec /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.2-4.fc27.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.2-4.fc27.x86_64.rpm rpmbuild/SPECS/dataagregator.spec:16: W: unversioned-explicit-provides bundled(qsshlib) rpmbuild/SPECS/dataagregator.spec:30: W: setup-not-quiet dataagregator.src: E: summary-too-long C Program for extracting information from multiple remote servers via ssh simultaneously dataagregator.src: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.src: W: spelling-error %description -l en_US json -> son, j son dataagregator.src:16: W: unversioned-explicit-provides bundled(qsshlib) dataagregator.src:30: W: setup-not-quiet dataagregator.x86_64: E: summary-too-long C Program for extracting information from multiple remote servers via ssh simultaneously dataagregator.x86_64: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.x86_64: W: spelling-error %description -l en_US json -> son, j son dataagregator.x86_64: W: no-manual-page-for-binary DataAgregator 2 packages and 1 specfiles checked; 2 errors, 9 warnings. ^^ Just a few little errors need to be solved. + final provides and requires are sane. SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. I think your package needs ExcludeArch 2. rpmlint errors If you would like to be sponsored, I advise you to do informal review on other review requests, you need to show you're interested in packaging and you need to know packaging [0] and reviewing [1] guidelines. [0] https://fedoraproject.org/wiki/Packaging:Guidelines [1] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines Personnaly, your software interests me, I will try it soon. By the way, did you ever try it with ssh key?
(In reply to VincentS from comment #3) > Hello, > I'm not yet a packager, so this is an unofficial review. > > > Package Review > ============== > > REVIEW: > > + OK > - NA > X ISSUE > > + Package meets naming and packaging guidelines. > + Spec file matches base package name. > + Spec has consistant macro usage. > + Meets Packaging Guidelines. > + License > + License field in spec matches > ^^ > I'm not sure about license files. > I haven't seen information about MIT, GPLv3+ or BSD. > > + License file included in package > + Spec in American English > + Spec is legible. > + Sources match upstream sha256sum: > $ sha256sum 0.9.2.tar.gz rpmbuild/SOURCES/dataagregator-0.9.2.tar.gz > 2df8316e0b9eab76425f83c38a79f9f6a341767803ca268fe571ed2c8fc1871f > 0.9.2.tar.gz > 2df8316e0b9eab76425f83c38a79f9f6a341767803ca268fe571ed2c8fc1871f > rpmbuild/SOURCES/dataagregator-0.9.2.tar.gz > > X Package needs ExcludeArch > ^^ > I think you may add exclude arch, as you can see in the following link. > https://koji.fedoraproject.org/koji/taskinfo?taskID=18275674 > > + BuildRequires correct > - Spec handles locales/find_lang > - Package is relocatable and has a reason to be. > + Package has %defattr and permissions on files is good. > $ rpmls > /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.2-4.fc27.x86_64. > rpm -rwxr-xr-x /usr/bin/DataAgregator > drwxr-xr-x /usr/share/doc/dataagregator > -rw-r--r-- /usr/share/doc/dataagregator/README.md > drwxr-xr-x /usr/share/licenses/dataagregator > -rw-r--r-- /usr/share/licenses/dataagregator/COPYING > -rw-r--r-- /usr/share/licenses/dataagregator/license.txt > > + Package is code or permissible content. > + Doc subpackage needed/used. > + Packages %doc files don't affect runtime. > > - Headers/static libs in -devel subpackage. > - Spec has needed ldconfig in post and postun > - .pc files in -devel subpackage/requires pkgconfig > - .so files in -devel subpackage. > - -devel package Requires: %{name} = %{version}-%{release} > - .la files are removed. > > - Package is a GUI app and has a .desktop file > > + Package compiles and builds on at least one arch. > + Package has no duplicate files in %files. > + Package doesn't own any directories other packages own. > + Package owns all the directories it creates. > X Rpmlint output: > $ rpmlint rpmbuild/SPECS/dataagregator.spec > /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.2-4.fc27.src. > rpm > /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.2-4.fc27.x86_64. > rpm > rpmbuild/SPECS/dataagregator.spec:16: W: unversioned-explicit-provides > bundled(qsshlib) > rpmbuild/SPECS/dataagregator.spec:30: W: setup-not-quiet > dataagregator.src: E: summary-too-long C Program for extracting information > from multiple remote servers via ssh simultaneously > dataagregator.src: W: spelling-error %description -l en_US agregation -> > aggregation, segregation, congregation > dataagregator.src: W: spelling-error %description -l en_US json -> son, j son > dataagregator.src:16: W: unversioned-explicit-provides bundled(qsshlib) > dataagregator.src:30: W: setup-not-quiet > dataagregator.x86_64: E: summary-too-long C Program for extracting > information from multiple remote servers via ssh simultaneously > dataagregator.x86_64: W: spelling-error %description -l en_US agregation -> > aggregation, segregation, congregation > dataagregator.x86_64: W: spelling-error %description -l en_US json -> son, j > son > dataagregator.x86_64: W: no-manual-page-for-binary DataAgregator > 2 packages and 1 specfiles checked; 2 errors, 9 warnings. > ^^ > Just a few little errors need to be solved. > > + final provides and requires are sane. > > > SHOULD Items: > > + Should build in mock. > + Should build on all supported archs > - Should function as described. > - Should have sane scriptlets. > - Should have subpackages require base package with fully versioned depend. > + Should have dist tag > + Should package latest version > - check for outstanding bugs on package. (For core merge reviews) > > Issues: > > 1. I think your package needs ExcludeArch > 2. rpmlint errors > > If you would like to be sponsored, I advise you to do informal review on > other review requests, you need to show you're interested in packaging and > you need to know packaging [0] and reviewing [1] guidelines. > > [0] https://fedoraproject.org/wiki/Packaging:Guidelines > [1] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines > > Personnaly, your software interests me, I will try it soon. > By the way, did you ever try it with ssh key? Thank you for attention, I will fix your issues in the nearest time. Utility is not supported ssh keys yet, but this is not a problem to add this feature in next realease, if somebody will test it. In my work environments, where I use this utility, the servers are virtuals that reinstalls very often, and this means that I need to copy my key to all servers each time after redeploy. Therefore, I cann't test this feature in production mode.
Spec URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/40437e8d67a6c87b8fe04ceec06e21f02d5ae62a/Fedora/dataagregator.spec SRPM URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/40437e8d67a6c87b8fe04ceec06e21f02d5ae62a/Fedora/dataagregator-0.9.3-1.fc25.src.rpm Spec file was updared after review. SRPM was builded on all supported by fedora platforms: https://koji.fedoraproject.org/koji/taskinfo?taskID=18287948
For me, the package is ok. Package Review ============== REVIEW: + OK - NA X ISSUE + Package meets naming and packaging guidelines. + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches ^^ I'm not sure about license files. I haven't seen information about MIT, GPLv3+ or BSD. + License file included in package + Spec in American English + Spec is legible. + Sources match upstream sha256sum: $ sha256sum 0.9.3.tar.gz rpmbuild/SOURCES/dataagregator-0.9.3.tar.gz 7155278107f56a01bf90b9df7a743744643cfbd59eb726f7629b9a7c44768763 0.9.3.tar.gz 7155278107f56a01bf90b9df7a743744643cfbd59eb726f7629b9a7c44768763 rpmbuild/SOURCES/dataagregator-0.9.3.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. $ rpmls /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.3-1.fc27.x86_64.rpm -rwxr-xr-x /usr/bin/DataAgregator drwxr-xr-x /usr/share/doc/dataagregator -rw-r--r-- /usr/share/doc/dataagregator/README.md drwxr-xr-x /usr/share/licenses/dataagregator -rw-r--r-- /usr/share/licenses/dataagregator/COPYING + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + Rpmlint output: $ rpmlint rpmbuild/SPECS/dataagregator.spec /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.3-1.fc27.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/dataagregator-0.9.3-1.fc27.x86_64.rpm dataagregator.src: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.src: W: spelling-error %description -l en_US json -> son, j son dataagregator.x86_64: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.x86_64: W: spelling-error %description -l en_US json -> son, j son dataagregator.x86_64: W: no-manual-page-for-binary DataAgregator 2 packages and 1 specfiles checked; 0 errors, 5 warnings. + final provides and requires are sane. SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) No issues.
Hello Mikhail, - Please update to 0.9.4 - Typo in the description: agregation → aggregation - Please add a comment before License: explaining what parts of the code is covered by which license. QSshLib seems GPLv3 and the rest MIT. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (unspecified)", "GPL (v3)", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/dataagregator/review- dataagregator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dataagregator-debuginfo , dataagregator-debugsource [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dataagregator-0.9.4-1.fc28.x86_64.rpm dataagregator-debuginfo-0.9.4-1.fc28.x86_64.rpm dataagregator-debugsource-0.9.4-1.fc28.x86_64.rpm dataagregator-0.9.4-1.fc28.src.rpm dataagregator.x86_64: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.x86_64: W: spelling-error %description -l en_US json -> son, j son dataagregator.x86_64: W: only-non-binary-in-usr-lib dataagregator.x86_64: W: no-manual-page-for-binary DataAgregator dataagregator-debugsource.x86_64: W: no-documentation dataagregator.src: W: spelling-error %description -l en_US agregation -> aggregation, segregation, congregation dataagregator.src: W: spelling-error %description -l en_US json -> son, j son dataagregator.src:55: W: macro-in-%changelog %setup dataagregator.src:55: W: macro-in-%changelog %autosetup 4 packages and 0 specfiles checked; 0 errors, 9 warnings.
Spec URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/5a01cabb1dff85cda9ab7083495d04399fe1a851/Fedora/dataagregator.spec SRPM URL: https://bitbucket.org/milovidov/dataagregatorinstallers/raw/5a01cabb1dff85cda9ab7083495d04399fe1a851/Fedora/dataagregator-1.0.0-2.fc26.src.rpm Spec file was updated after review. Also updated version of DataAgregator up to 1.0.0. In new version of DataAgregator: 1. Support for ssh keys was added 2. Added user folder for general configs, for linux this is ~/.local/share/DataAgregator.
All ok then, package accepted.
(In reply to Robert-André Mauchin from comment #9) > All ok then, package accepted. The problem is that reporter is not sponsored, so you just hiding ticket from the queue ;) I will be taking this.
(In reply to Igor Gnatenko from comment #10) > The problem is that reporter is not sponsored, so you just hiding ticket > from the queue ;) > > I will be taking this. So? :)
Ugh, I entirely forgot about this ticket in my queue.
I have sponsored you, don't hesitate to ask me any questions.
Is it alive?
After application rebrending this app were published by another name - https://bodhi.fedoraproject.org/updates/?packages=daggy.