Bug 1429945 - Disabling NSS_ENABLE_ECC not fully honoured
Summary: Disabling NSS_ENABLE_ECC not fully honoured
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: nss-softokn
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: nss-nspr-maint
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-07 14:43 UTC by Paul Wouters
Modified: 2018-11-27 14:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-11-27 14:04:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Paul Wouters 2017-03-07 14:43:45 UTC
Description of problem:

Compiling without export NSS_ENABLE_ECC=1 fails

On rawhide it works, but it turns out ECC code is compiled in, and the tool ecperf is compiled and packaged.

While not a big problem, the reason I found this bug is that I wanted to compile this on older versions of fedora where there truly no openssl ECC support, and then compilation fails on:

ecperf.c: In function 'main':
ecperf.c:282:66: error: 'ec_field_plain' undeclared (first use in this function)
         rv = ectest_curve_freebl(name_v, iterations, numThreads, ec_field_plain); \
                                                                  ^
ecperf.c:716:9: note: in expansion of macro 'ECTEST_NAMED_CUSTOM'
         ECTEST_NAMED_CUSTOM("Curve25519", ECCurve25519);
         ^
ecperf.c:282:66: note: each undeclared identifier is reported only once for each function it appears in
         rv = ectest_curve_freebl(name_v, iterations, numThreads, ec_field_plain); \
                                                                  ^
ecperf.c:716:9: note: in expansion of macro 'ECTEST_NAMED_CUSTOM'
         ECTEST_NAMED_CUSTOM("Curve25519", ECCurve25519);
         ^
../../coreconf/rules.mk:392: recipe for target 'Linux4.0_x86_64_cc_glibc_PTH_64_OPT.OBJ/ecperf.o' failed
make[2]: *** [Linux4.0_x86_64_cc_glibc_PTH_64_OPT.OBJ/ecperf.o] Error 1

Which leads me to believe there might be ECC code compiled in even when not setting NSS_ENABLE_ECC

Comment 1 Kai Engert (:kaie) (inactive account) 2017-03-07 14:55:49 UTC
Paul, I believe it's no longer required to set NSS_ENABLE_ECC, and it's indeed enabled by default.

The bug contains too little specific information to help you.

Comment 2 Paul Wouters 2017-03-07 15:06:22 UTC
Patching so ecperf and fbectest are unset in nss/cmd/Makefile got my further but compiling still fails trying to bring in ECC code.

Setting NSS_DISABLE_ECC=1 did not work, and adding -DNSS_DISABLE_ECC=1 via 

    XCFLAGS="$RPM_OPT_FLAGS -DNSS_DISABLE_ECC=1"

in the spec file failed showing it still linked in ECC parts:

Linux4.0_x86_64_cc_glibc_PTH_64_OPT.OBJ/Linux_SINGLE_SHLIB/ldvector.o:(.data.rel.ro.vector+0x6b8): undefined reference to `EC_GetPointSize'
collect2: error: ld returned 1 exit status
../../coreconf/rules.mk:289: recipe for target 'Linux4.0_x86_64_cc_glibc_PTH_64_OPT.OBJ/Linux_SINGLE_SHLIB/libfreeblpriv3.so' failed
make[3]: *** [Linux4.0_x86_64_cc_glibc_PTH_64_OPT.OBJ/Linux_SINGLE_SHLIB/libfreeblpriv3.so] Error 1
make[3]: Leaving directory '/root/rpmbuild/BUILD/nss-softokn-3.29.1/nss/lib/freebl'

Comment 3 Jan Kurik 2017-08-15 06:55:57 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 4 Ben Cotton 2018-11-27 13:51:53 UTC
This message is a reminder that Fedora 27 is nearing its end of life.
On 2018-Nov-30  Fedora will stop maintaining and issuing updates for
Fedora 27. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora  'version' of '27'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 27 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Daiki Ueno 2018-11-27 14:04:40 UTC
NSS_DISABLE_ECC was also removed around that time and has no effect these days:
https://hg.mozilla.org/projects/nss/rev/69242366eb81
https://hg.mozilla.org/projects/nss/rev/a4d29d214611

Closing this as not a bug.


Note You need to log in before you can comment on or make changes to this bug.