Bug 1430032 - Color variable typo in mate-applications.css
Summary: Color variable typo in mate-applications.css
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mate-themes
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Wolfgang Ulbrich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-07 17:16 UTC by Bruce Jerrick
Modified: 2017-04-04 17:24 UTC (History)
2 users (show)

Fixed In Version: mate-themes-3.22.8-1.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-02 20:53:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
latest patch broke submarine themes as read by mate-menu (465.15 KB, image/png)
2017-04-04 10:25 UTC, Mike Simms
no flags Details

Description Bruce Jerrick 2017-03-07 17:16:48 UTC
Description of problem:
There's a typo in the Caja section of /usr/share/themes/TraditionalOk/\
gtk-3.0/mate-applications.css:
    color: @theme_sectected_fg_color;
That should be "selected", not "sectected" .

Version-Release number of selected component:
mate-themes-3.22.7-1.fc25.noarch

Steps to Reproduce:
1. grep "sectected" /usr/share/themes/TraditionalOk/gtk-3.0/mate-applications.css

Actual results:
    color: @theme_sectected_fg_color;

Expected results:
No match.

Additional info:
I don't use caja, so I don't know what the effects are, but obviously it's
a mistake (I see no other instances of "sectected" anywhere under
/usr/share/themes/).

Comment 1 Wolfgang Ulbrich 2017-03-07 17:44:13 UTC
Thanks for the hint.
I fixed that at upstream for all gtk+ branches.
https://github.com/mate-desktop/mate-themes/commit/29eb147f1a6cbbf605e5b18a3f0c734439743111

Comment 2 Fedora Update System 2017-03-30 13:22:43 UTC
mate-themes-3.22.8-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fab848dafc

Comment 3 Fedora Update System 2017-03-31 03:22:23 UTC
mate-themes-3.22.8-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fab848dafc

Comment 4 Fedora Update System 2017-04-02 20:53:34 UTC
mate-themes-3.22.8-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 5 Mike Simms 2017-04-04 10:25:13 UTC
Created attachment 1268595 [details]
latest patch broke submarine themes as read by mate-menu

after installing the latest mate-themes patch to correct the css issue, I know have this when using mate-menu for blue-submarine or green-submarine. both exhibit the same problem. the menu should be all grey and not half and half

Comment 6 Wolfgang Ulbrich 2017-04-04 10:44:25 UTC
Damned, this regression is caused by
https://github.com/mate-desktop/mate-themes/commit/46f2dcfba225892351faf36b16e7cd0fea6479b4
and the follower
https://github.com/mate-desktop/mate-themes/commit/eff92ab9ab98f56de0fe8cff1dff2ac59a914faf
I fixed that for ubuntu-mate-themes already but i forgot to add this to mate-themes.
https://github.com/flexiondotorg/ubuntu-mate-themes/commit/5f325bb35a23bb9ccdcb5e32a699e52a8706daae
I will fix that soon.
thx

Comment 7 Mike Simms 2017-04-04 11:31:31 UTC
thanks, in the meantime using mate-menu preferences I just set the theme to use custom colours for background, border and heading colours which does the necessary to make it look normal again.

Comment 8 Wolfgang Ulbrich 2017-04-04 14:08:55 UTC
Mike,
this should fix the issue
https://github.com/mate-desktop/mate-themes/commit/861fdaff0a40a929e2c3d1aa6270c9bac246af29

Please apply that by hand, i will push out new releases soon as possible.

Comment 9 Mike Simms 2017-04-04 17:24:38 UTC
Many thanks Wolfgang, those modifications fixed it


Note You need to log in before you can comment on or make changes to this bug.