Bug 1430107 - Review Request: python-pymacaroons-pynacl - a Python implementation of Macaroons
Summary: Review Request: python-pymacaroons-pynacl - a Python implementation of Macar...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-07 21:31 UTC by Jeremy Cline
Modified: 2019-09-17 15:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-09-17 15:44:28 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Jeremy Cline 2017-03-07 21:31:59 UTC
Spec URL: https://jcline.fedorapeople.org/python-pymacaroons-pynacl.spec
SRPM URL: https://jcline.fedorapeople.org/python-pymacaroons-pynacl-0.9.3-1.fc25.src.rpm
Description:
Macaroons, like cookies, are a form of bearer credential. Unlike
opaque tokens, macaroons embed caveats that define specific authorization
requirements for the target service, the service that issued the root macaroon
and which is capable of verifying the integrity of macaroons it receives.

Macaroons allow for delegation and attenuation of authorization. They are
simple and fast to verify, and decouple authorization policy from the
enforcement of that policy.


Fedora Account System Username: jcline

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18254673

Comment 1 Zbigniew Jędrzejewski-Szmek 2017-03-13 14:36:26 UTC
The %description and Summary are rather opaque for people who do not already know what Macaroon is. Consider changing the summary to something like

  Summary: Library providing non-opaque cookies for authorization

and adding "This is a Python reimplementation of ... originally written in ...".

+ package name is OK
+ builds and installs OK
+ fedora-review has no complaints
+ BR/R/P look correct
+ modern python packaging template is used
+ %python_provide are present
+ license is acceptable (MIT)
+ license is specified correctly

Package is APPROVED.

Comment 2 Jeremy Cline 2017-03-13 15:28:37 UTC
Great suggestions, thanks!

Comment 3 Gwyn Ciesla 2017-03-13 17:21:11 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pymacaroons-pynacl


Note You need to log in before you can comment on or make changes to this bug.