Bug 1430241 - Openstack infra provider dashboard should not appear for an openstack infra provider
Summary: Openstack infra provider dashboard should not appear for an openstack infra p...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.10.0
Assignee: Harpreet Kataria
QA Contact: Omri Hochman
URL:
Whiteboard: openstack
Depends On:
Blocks: 1462361 1553345
TreeView+ depends on / blocked
 
Reported: 2017-03-08 06:47 UTC by Ronnie Rasouli
Modified: 2019-02-11 13:55 UTC (History)
9 users (show)

Fixed In Version: 5.10.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1462361 1553345 (view as bug list)
Environment:
Last Closed: 2019-02-11 13:55:57 UTC
Category: Bug
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Infra provider dashboard (77.56 KB, image/png)
2017-03-08 06:47 UTC, Ronnie Rasouli
no flags Details
provider dashboard (90.00 KB, image/png)
2018-02-20 13:13 UTC, Jad Haj Yahya
no flags Details

Description Ronnie Rasouli 2017-03-08 06:47:57 UTC
Created attachment 1261096 [details]
Infra provider dashboard

Description of problem:

The default dashboard display show wrong openstack terminology
openstack infra provider nodes as hosts
openstack deployment roles as clusters


Version-Release number of selected component (if applicable):
5.8.0.3

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Tzu-Mainn Chen 2017-03-08 18:44:20 UTC
We don't really have an openstack infra dashboard; it was created for other infra providers, and we won't be able to create an openstack-specific dashboard for a while.  Ronnie, I might suggest closing this BZ and creating a new one, saying that the current infra dashboard should not appear for an openstack infra provider.

Comment 8 CFME Bot 2017-06-16 18:19:25 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/7cd9550bc07e5f0f39abb2ec70c7485647410d5f

commit 7cd9550bc07e5f0f39abb2ec70c7485647410d5f
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jun 16 12:33:20 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Jun 16 13:09:23 2017 -0400

    Fixed titles and labels for Hosts & Clusters Openstack Providers
    
    - Changed to show Nodes/Deployment Roles as titles for Hosts/Clusters for Openstack Dashboards charts where appropriate on screen.
    - Removed Datastores count chart for Openstack Provider.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1430241

 .../ems_infra_dashboard_controller.js              |  3 +++
 .../util/infra-dashboard-utils-factory.js          |  5 ++--
 app/services/ems_infra_dashboard_service.rb        | 31 +++++++++++++++-------
 app/views/ems_infra/_show_dashboard.html.haml      | 15 ++++++-----
 .../json/ems_infra_dashboard_no_data_response.json | 10 +++++++
 .../json/ems_infra_dashboard_response.json         | 10 +++++++
 6 files changed, 56 insertions(+), 18 deletions(-)

Comment 9 CFME Bot 2017-06-16 18:19:30 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/d176b65fd86f4358c91cef845ed51de5c3269ce9

commit d176b65fd86f4358c91cef845ed51de5c3269ce9
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jun 16 13:26:50 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Jun 16 13:26:50 2017 -0400

    Addressed code climate warnings.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1430241

 .../util/infra-dashboard-utils-factory.js          |  3 ++-
 app/services/ems_infra_dashboard_service.rb        | 31 ++++++++++------------
 2 files changed, 16 insertions(+), 18 deletions(-)

Comment 11 Jad Haj Yahya 2018-02-20 13:13:25 UTC
Created attachment 1398220 [details]
provider dashboard

Comment 12 Jad Haj Yahya 2018-02-20 13:14:12 UTC
tested on RHOS 11, 5.9.0.21
please see attachment on previous comment

Comment 14 CFME Bot 2018-03-02 13:29:23 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/c8bcff5bfb018d53db75f89a1a8222f1c956d76d

commit c8bcff5bfb018d53db75f89a1a8222f1c956d76d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Mar 1 13:53:36 2018 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Mar 1 14:25:24 2018 -0500

    Fixed labels for Openstack Provider
    
    Fixed labels on all "Clusters" and "Hosts" related cards for Openstack providers to "Deployment Roles" and "Nodes"
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1430241

 .../aggregate_status_card_controller.js            | 17 +++++++++--------
 .../ems_infra_dashboard/charts-mixin.js            |  9 +++++----
 .../recent_hosts_line_chart_controller.js          |  1 +
 .../recent_vms_line_chart_controller.js            |  1 +
 app/services/ems_infra_dashboard_service.rb        | 22 ++++++++++++----------
 5 files changed, 28 insertions(+), 22 deletions(-)

Comment 17 Jad Haj Yahya 2018-07-08 10:00:23 UTC
Verified on 5.10.0.3


Note You need to log in before you can comment on or make changes to this bug.