Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1430491

Summary:	Make guaranteed memory hot-settable when memory is hotplugged
Product:	[oVirt] ovirt-engine	Reporter:	jniederm
Component:	BLL.Virt	Assignee:	jniederm
Status:	CLOSED CURRENTRELEASE	QA Contact:	Israel Pinto <ipinto>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	future	CC:	bugs, michal.skrivanek, msivak, tjelinek, ylavi
Target Milestone:	ovirt-4.2.0	Flags:	rule-engine: ovirt-4.2+ ipinto: testing_ack+
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 10:51:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jniederm 2017-03-08 18:33:52 UTC

Description of problem:
Currently if memory size is changed in UI value of memory guaranteed is updated. How ever no matter what the state of edited VM is, the change has no effect on current run of VM.

Intended state is to hot-set value of memory guaranteed if
* it is changed (both directly or indirectly by change of memory size in UI)
* AND VM is UP
* AND memory hotplug is performed at the same time.

Comment 1 Michal Skrivanek 2017-03-09 05:31:19 UTC

Simple extension of current hotset memory verb in vdsm would do.  
Martin, thoughts on automatically updating the value in GUI while VM is Up vs leaving it be in that case(similar to bug 1430451)

Comment 2 Martin Sivák 2017-06-01 08:39:28 UTC

I do not have any preference actually. I would expect the value to be changed when in default state and left intact when user defined number is there. This is not easy to distinguish though..

Comment 3 Michal Skrivanek 2017-06-01 08:57:20 UTC

(In reply to Martin Sivák from comment #2)
> I do not have any preference actually. I would expect the value to be
> changed when in default state and left intact when user defined number is
> there. This is not easy to distinguish though..

so that's what it does, but the question is about behavior when the VM is currently Up, if such a change (when in the default state) is applied immediately on the running VM or not

Comment 4 Martin Sivák 2017-06-01 09:21:37 UTC

Well it is not as nobody sends it to the host. This bug is about making it possible right? And I think it makes sense to allow "hotplug" of this value.

Comment 5 Michal Skrivanek 2017-11-21 09:44:45 UTC

this one requires documentation

Comment 6 Red Hat Bugzilla Rules Engine 2017-11-21 09:44:50 UTC

The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 7 Israel Pinto 2017-11-27 14:42:36 UTC

Verify with:
Software version:4.2.0-0.5.master.el7

Steps:
1. Create VM with OS with 1G memory
2. Hotplug memory of 1G 
3. Hot unplug 1G

Results:
Hotplug: Guaranteed memory is updated to define memory
Hot unplug: Guaranteed memory is updated to define memory

PASS

Comment 8 Sandro Bonazzola 2017-12-20 10:51:23 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.