Bug 1431087 - Review Request: perl-Protocol-HTTP2 - HTTP/2 protocol implementation (RFC 7540)
Summary: Review Request: perl-Protocol-HTTP2 - HTTP/2 protocol implementation (RFC 7540)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-10 10:52 UTC by Petr Pisar
Modified: 2017-03-14 13:55 UTC (History)
2 users (show)

Fixed In Version: perl-Protocol-HTTP2-1.08-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-14 13:55:49 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-10 10:52:24 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Protocol-HTTP2/perl-Protocol-HTTP2.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Protocol-HTTP2/perl-Protocol-HTTP2-1.08-1.fc27.src.rpm
Description:
Protocol::HTTP2 is Perl HTTP/2 protocol implementation (RFC 7540) with
stateful decoders/encoders of HTTP/2 frames. You may use this module to
implement your own HTTP/2 client/server/intermediate on top of your favorite
event loop over plain or TLS socket.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-14 12:18:22 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpmlint ./perl-Protocol-HTTP2*
perl-Protocol-HTTP2.noarch: W: spelling-error %description -l en_US stateful -> tasteful, wasteful, fateful
perl-Protocol-HTTP2.src: W: spelling-error %description -l en_US stateful -> tasteful, wasteful, fateful
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

FIX: Please add BR perl-generators to fix binary requires and provides.

Otherwise package looks good.

Comment 2 Petr Pisar 2017-03-14 12:22:06 UTC
Updated package is on the same address.

Comment 3 Jitka Plesnikova 2017-03-14 12:40:05 UTC
> FIX: Please add BR perl-generators to fix binary requires and provides.
 BuildRequires:  perl-devel
+BuildRequires:  perl-generators
 BuildRequires:  perl(Module::Build::Tiny) >= 0.035
Ok.

$ rpm -qp --requires perl-Protocol-HTTP2-1.08-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.8.5
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(MIME::Base64) >= 3.11
      1 perl(Protocol::HTTP2)
      1 perl(Protocol::HTTP2::Connection)
      1 perl(Protocol::HTTP2::Constants)
      1 perl(Protocol::HTTP2::Frame)
      1 perl(Protocol::HTTP2::Frame::Continuation)
      1 perl(Protocol::HTTP2::Frame::Data)
      1 perl(Protocol::HTTP2::Frame::Goaway)
      1 perl(Protocol::HTTP2::Frame::Headers)
      1 perl(Protocol::HTTP2::Frame::Ping)
      1 perl(Protocol::HTTP2::Frame::Priority)
      1 perl(Protocol::HTTP2::Frame::Push_promise)
      1 perl(Protocol::HTTP2::Frame::Rst_stream)
      1 perl(Protocol::HTTP2::Frame::Settings)
      1 perl(Protocol::HTTP2::Frame::Window_update)
      1 perl(Protocol::HTTP2::HeaderCompression)
      1 perl(Protocol::HTTP2::Huffman)
      1 perl(Protocol::HTTP2::HuffmanCodes)
      1 perl(Protocol::HTTP2::StaticTable)
      1 perl(Protocol::HTTP2::Stream)
      1 perl(Protocol::HTTP2::Trace)
      1 perl(Protocol::HTTP2::Upgrade)
      1 perl(Scalar::Util)
      1 perl(Time::HiRes)
      1 perl(constant)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Protocol-HTTP2-1.08-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Protocol::HTTP2) = 1.08
      1 perl(Protocol::HTTP2::Client)
      1 perl(Protocol::HTTP2::Connection)
      1 perl(Protocol::HTTP2::Constants)
      1 perl(Protocol::HTTP2::Frame)
      1 perl(Protocol::HTTP2::Frame::Continuation)
      1 perl(Protocol::HTTP2::Frame::Data)
      1 perl(Protocol::HTTP2::Frame::Goaway)
      1 perl(Protocol::HTTP2::Frame::Headers)
      1 perl(Protocol::HTTP2::Frame::Ping)
      1 perl(Protocol::HTTP2::Frame::Priority)
      1 perl(Protocol::HTTP2::Frame::Push_promise)
      1 perl(Protocol::HTTP2::Frame::Rst_stream)
      1 perl(Protocol::HTTP2::Frame::Settings)
      1 perl(Protocol::HTTP2::Frame::Window_update)
      1 perl(Protocol::HTTP2::HeaderCompression)
      1 perl(Protocol::HTTP2::Huffman)
      1 perl(Protocol::HTTP2::HuffmanCodes)
      1 perl(Protocol::HTTP2::Server)
      1 perl(Protocol::HTTP2::Server::Stream)
      1 perl(Protocol::HTTP2::StaticTable)
      1 perl(Protocol::HTTP2::Stream)
      1 perl(Protocol::HTTP2::Trace)
      1 perl(Protocol::HTTP2::Upgrade)
      1 perl-Protocol-HTTP2 = 1.08-1.fc27
Binary provides are Ok.

Approved

Comment 4 Gwyn Ciesla 2017-03-14 13:05:16 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Protocol-HTTP2

Comment 5 Petr Pisar 2017-03-14 13:55:49 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.