Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1431182

Summary: engine-backup accepts same filename for backup archive and backup log
Product: [oVirt] ovirt-engine Reporter: Jiri Belka <jbelka>
Component: Backup-Restore.EngineAssignee: Asaf Rachmani <arachman>
Status: CLOSED CURRENTRELEASE QA Contact: Lukas Svaty <lsvaty>
Severity: low Docs Contact:
Priority: low    
Version: ---CC: arachman, bugs, lsvaty
Target Milestone: ovirt-4.3.0Flags: rule-engine: ovirt-4.3+
Target Release: 4.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_alpha Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-13 07:46:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jiri Belka 2017-03-10 14:28:47 UTC 
Description of problem:

engine-backup accepts same filename for backup archive and backup log, thus the log is lost. (otherway round, ie. first log then backup file on cmd line causes error.)

# engine-backup --mode=backup --file=backup_pinning --log=backup_pinning --scope=all
Backing up:
Notifying engine
- Files
- Engine database 'engine'
Packing into file 'backup_pinning'
Notifying engine
Done.
------------------------------------------------------------------------
Please note:

If you are running engine-backup as part of a migration to 4.0,
please refer to the Red Hat Virtualization Upgrade Helper:

https://access.redhat.com/labsinfo/rhevupgradehelper
------------------------------------------------------------------------
[root@jbelka-vm4 ~]# ls backup_pinning*
backup_pinning
[root@jbelka-vm4 ~]# gunzip -c backup_pinning | tar -tf -
./
./config
./files
./db/
./db/engine_backup.db
./os_version
./version
./md5sum

gzip: backup_pinning: decompression OK, trailing garbage ignored


Version-Release number of selected component (if applicable):
rhevm-tools-backup-3.6.10.2-0.2.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. run engine-backup with same filename for file and log
2.
3.

Actual results:
engine-backup runs and the consequence is there's no log

Expected results:
imo it should error about filename mismatch/duplicity

Additional info:
Comment 1 Jiri Belka 2018-08-30 07:42:53 UTC 
ok, ovirt-engine-tools-backup-4.3.0-0.0.master.20180828114844.git0bc18b1.el7.noarch

# engine-backup --file=/tmp/backup-test --log=/tmp/backup-test --mode=backup
FATAL: --file and --log can not be the same
Notifying engine
FATAL: Failed notifying engine

# engine-backup --log=/tmp/backup-test --file=/tmp/backup-test --mode=backup
FATAL: --file and --log can not be the same
Notifying engine
FATAL: Failed notifying engine
Comment 3 Sandro Bonazzola 2018-11-02 14:29:57 UTC 
This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Comment 4 Sandro Bonazzola 2018-11-02 14:47:44 UTC 
Closed by mistake, moving back to qa -> verified
Comment 5 Sandro Bonazzola 2019-02-13 07:46:38 UTC 
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.