Bug 1431182 - engine-backup accepts same filename for backup archive and backup log
Summary: engine-backup accepts same filename for backup archive and backup log
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backup-Restore.Engine
Version: ---
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-4.3.0
: 4.3.0
Assignee: Asaf Rachmani
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-10 14:28 UTC by Jiri Belka
Modified: 2019-02-13 07:46 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.3.0_alpha
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-13 07:46:38 UTC
oVirt Team: Integration
Embargoed:
rule-engine: ovirt-4.3+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 91655 0 master MERGED packaging: engine-backup: Prevent use of same filename in --file and --log 2020-05-19 13:56:38 UTC

Description Jiri Belka 2017-03-10 14:28:47 UTC
Description of problem:

engine-backup accepts same filename for backup archive and backup log, thus the log is lost. (otherway round, ie. first log then backup file on cmd line causes error.)

# engine-backup --mode=backup --file=backup_pinning --log=backup_pinning --scope=all
Backing up:
Notifying engine
- Files
- Engine database 'engine'
Packing into file 'backup_pinning'
Notifying engine
Done.
------------------------------------------------------------------------
Please note:

If you are running engine-backup as part of a migration to 4.0,
please refer to the Red Hat Virtualization Upgrade Helper:

https://access.redhat.com/labsinfo/rhevupgradehelper
------------------------------------------------------------------------
[root@jbelka-vm4 ~]# ls backup_pinning*
backup_pinning
[root@jbelka-vm4 ~]# gunzip -c backup_pinning | tar -tf -
./
./config
./files
./db/
./db/engine_backup.db
./os_version
./version
./md5sum

gzip: backup_pinning: decompression OK, trailing garbage ignored


Version-Release number of selected component (if applicable):
rhevm-tools-backup-3.6.10.2-0.2.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. run engine-backup with same filename for file and log
2.
3.

Actual results:
engine-backup runs and the consequence is there's no log

Expected results:
imo it should error about filename mismatch/duplicity

Additional info:

Comment 1 Jiri Belka 2018-08-30 07:42:53 UTC
ok, ovirt-engine-tools-backup-4.3.0-0.0.master.20180828114844.git0bc18b1.el7.noarch

# engine-backup --file=/tmp/backup-test --log=/tmp/backup-test --mode=backup
FATAL: --file and --log can not be the same
Notifying engine
FATAL: Failed notifying engine

# engine-backup --log=/tmp/backup-test --file=/tmp/backup-test --mode=backup
FATAL: --file and --log can not be the same
Notifying engine
FATAL: Failed notifying engine

Comment 3 Sandro Bonazzola 2018-11-02 14:29:57 UTC
This bugzilla is included in oVirt 4.2.7 release, published on November 2nd 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 4 Sandro Bonazzola 2018-11-02 14:47:44 UTC
Closed by mistake, moving back to qa -> verified

Comment 5 Sandro Bonazzola 2019-02-13 07:46:38 UTC
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.