Spec URL: https://raw.githubusercontent.com/siwinski/rpms/ce04869657f814492a821b089d4f016c7719ae16/php-google-apiclient-services/php-google-apiclient-services.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-google-apiclient-services-0.10-1.fc25.src.rpm Description: Client library for Google APIs. Fedora Account System Username: siwinski
Created attachment 1262191 [details] phpci.log Note: phpCompatInfo version 5.0.4 DB version 1.18.0 built Feb 24 2017 14:37:58 CET static analyze results
Created attachment 1262192 [details] review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1431362 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api
[x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/Google(php- google-apiclient), /usr/share/php/Google/Service(php-google-apiclient) => ok, package splitted, conflicts present [x]: %check is present and all tests pass. => need to raise memory_limit for local build and php56 [x]: Package complies to the Packaging Guidelines No blockers === APPROVED ===
BTW, I just noticed (bug #1386152) you plan to create a php-google-apiclient2, so shouldn't this package avoid conflicts with v1 ?
(In reply to Remi Collet from comment #4) > BTW, I just noticed (bug #1386152) you plan to create a > php-google-apiclient2, so shouldn't this package avoid conflicts with v1 ? I'm rethinking that comment... https://bugzilla.redhat.com/show_bug.cgi?id=1386152#c7
Which option do you prefer?: 1) Create a "php-google-apiclient1" package that deprecates "php-google-apiclient < 2" and installs to "/usr/share/php/Google1" 2) Install this "php-google-apiclient-services" v0.10 package to "/usr/share/php/Google2" even though this package is neither the apiclient library nor is it v2. IMO, #1 because #2 installs to a location that doesn't really pertain to this package. I'm all for creating versioned install directories when they make sense, but I don't think it makes sense to install this package into a "Google2" directory. This package stand-alone doesn't make sense to install into "Google2".
I agree with you, #1 seems better
php-google-apiclient1 is now available in rawhide.
THANKS for the review. Pkgdb request submitted for rawhide and f26 (just like php-google-apiclient1).
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-google-apiclient-services
php-google-apiclient-services-0.11-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-76e0ca4687
php-google-apiclient-services-0.11-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-76e0ca4687
php-google-apiclient-services-0.11-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.