Spec URL: https://raw.githubusercontent.com/siwinski/rpms/210cbbdd7b62665e377f3fd43f60292a2390f192/php-phpdocumentor-reflection-common/php-phpdocumentor-reflection-common.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-phpdocumentor-reflection-common-1.0-1.fc25.src.rpm Description: Common reflection classes used by phpdocumentor to reflect the code structure. Fedora Account System Username: siwinski
It look likes you need this package for phpdocumentor/reflection-docblock 2 ? 3 ? Hmm... phpdocumentor-reflection 3 requires phpdocumentor/reflection-docblock: ~2.0 phpdocumentor/reflection-docblock 3 requires phpdocumentor/reflection-common: ^1.0 and phpdocumentor/type-resolver ^0.2.0 By luck, no conflicting files... BTW, shouldn't use a separate tree ?
Perhaps we need another layout... just need to think... will try to raise discussion on php-devel... Ex: /usr/share/%{name} (so outside include_path, but we don't need to have it in include_path as it is not PSR-0 and we provide an good autoloader...)
(In reply to Remi Collet from comment #2) > Perhaps we need another layout... just need to think... will try to raise > discussion on php-devel... > > Ex: /usr/share/%{name} (so outside include_path, but we don't need to have > it in include_path as it is not PSR-0 and we provide an good autoloader...) What about `/usr/share/composer/{vendor}/{project}` and/or `/usr/share/composer/{vendor}/{project}-v{major version}` (just in case there is ever an actual project name that would equal `{project}{major version}`)?
I don't like the idea of a "composer" tree, there is no link with the composer package. I'm fine with /usr/share/%{name} /usr/share/{vendor}/{project} /usr/share/{vendor}/{project}-v{major version} For now, we don't have any Guidelines about such case, but I think it is fine to invent new solutions
Kepping current layout seems ok now than #1442309 and #1442310 are approved
Created attachment 1275136 [details] phpci.log phpCompatInfo version 5.0.6 DB version 1.20.0 built Apr 14 2017 16:12:51 CEST static analyze results
Created attachment 1275137 [details] review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1431364 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api
[x]: Package complies to the Packaging Guidelines === APPROVED ===
THANKS for the review. Pkg request submitted for F26+.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-phpdocumentor-reflection-common
php-phpdocumentor-reflection-common-1.0-1.fc26 php-phpdocumentor-reflection-docblock2-2.0.4-5.fc26 php-phpdocumentor-reflection1-1.0.7-5.fc26 php-phpdocumentor-type-resolver-0.2.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-14cb178d90
php-phpdocumentor-reflection-common-1.0-1.fc26, php-phpdocumentor-reflection-docblock2-2.0.4-5.fc26, php-phpdocumentor-reflection1-1.0.7-5.fc26, php-phpdocumentor-type-resolver-0.2.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-14cb178d90
php-phpdocumentor-reflection-common-1.0-1.fc26, php-phpdocumentor-reflection-docblock2-2.0.4-5.fc26, php-phpdocumentor-reflection1-1.0.7-5.fc26, php-phpdocumentor-type-resolver-0.2.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.