Spec URL: http://dl.jujens.eu/SPECS/python-agate.spec SRPM URL: http://dl.jujens.eu/SRPMS/python-agate-1.6.0-1.gited9e179.fc25.src.rpm Description: agate is a Python data analysis library that is optimized for humans instead of machines. It is an alternative to numpy and pandas that solves real-world problems with readable code. agate was previously known as journalism.
I prefer to use source urls like: https://files.pythonhosted.org/packages/source/a/agate/agate-1.6.0.tar.gz makes things simpler or?
Package fails to build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21359176
> I prefer to use source urls So do I. However, here the release on pypi is missing the license. So I get the sources from github instead. > Package fails to build I was missing a BR, sorry. Fixed: https://koji.fedoraproject.org/koji/taskinfo?taskID=21380042
Thanks, can you update links in ticker making fedora-review able to find new spec and srpm?
I forgot, sorry about that. - SPEC: https://dl.jujens.eu/SPECS/python-agate.spec - SRPM: https://dl.jujens.eu/SRPMS/python-agate-1.6.0-2.gited9e179.fc26.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. /export/work/terjeros/review/1431420-python-agate/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 6 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. Can this be used in make in docs? [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-agate-1.6.0-2.gited9e179.fc26.noarch.rpm python3-agate-1.6.0-2.gited9e179.fc26.noarch.rpm python-agate-doc-1.6.0-2.gited9e179.fc26.noarch.rpm python-agate-1.6.0-2.gited9e179.fc26.src.rpm python2-agate.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python3-agate.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python-agate-doc.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python-agate.src: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- python2-agate.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python-agate-doc.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python3-agate.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- python2-agate (rpmlib, GLIBC filtered): python(abi) python-isodate python-parsedatetime python2-babel python2-leather python2-pytimeparse python2-six python2-slugify python-agate-doc (rpmlib, GLIBC filtered): python3-agate (rpmlib, GLIBC filtered): python(abi) python3-babel python3-isodate python3-leather python3-parsedatetime python3-pytimeparse python3-six python3-slugify Provides -------- python2-agate: python-agate python2-agate python2.7dist(agate) python2dist(agate) python-agate-doc: python-agate-doc python3-agate: python3-agate python3.6dist(agate) python3dist(agate) Source checksums ---------------- https://github.com/wireservice/agate/archive/ed9e179a9828f73e786038ca467facbf5c75ae89/agate-ed9e179a9828f73e786038ca467facbf5c75ae89.tar.gz : CHECKSUM(SHA256) this package : 08fde43bb4ab8b90220929a9651b7be4acd0230020cd6d3417a71e6614de1e6b CHECKSUM(SHA256) upstream package : 08fde43bb4ab8b90220929a9651b7be4acd0230020cd6d3417a71e6614de1e6b Please check the parallel make thingie on import. Package is APPROVED.
> Can this be used in make in docs? I don't think it is possible to build the doc in parallel nor that it will speed up the thing. Thanks for the review.
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-agate. You may create the branch "f27" using git in about 10 minutes.
python-agate-1.6.0-2.gited9e179.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-02b72f0b2e
python-agate-1.6.0-2.gited9e179.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-666266c3d7
python-agate-1.6.0-2.gited9e179.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f39ba6e765
python-agate-1.6.0-2.gited9e179.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-666266c3d7
python-agate-1.6.0-2.gited9e179.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f39ba6e765
python-agate-1.6.0-2.gited9e179.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-02b72f0b2e
python-agate-1.6.0-2.gited9e179.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-agate-1.6.0-2.gited9e179.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
python-agate-1.6.0-2.gited9e179.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.