Dockerfile URL: https://hhorak.fedorapeople.org/python-docker/Dockerfile Other files URL: https://hhorak.fedorapeople.org/python-docker/ Description: Python available as docker container, is a base platform for building and running various Python applications and frameworks. Python is an easy to learn, powerful programming language. It has efficient high-level data structures and a simple but effective approach to object-oriented programming. Python’s elegant syntax and dynamic typing, together with its interpreted nature, make it an ideal language for scripting and rapid application development in many areas on most platforms. Fedora Account System Username: hhorak
* Few labels are missing: [1] BZComponent, RUN or Usage, Help * Version label should be set to 0 [2] * help file missing [3] [1] https://fedoraproject.org/wiki/Container:Guidelines#LABELS [2] https://fedoraproject.org/wiki/Container:Guidelines#VERSIONING [3] https://fedoraproject.org/wiki/Container:Guidelines#Help_File
Thanks for the review, it's now fixed: ... ENV NAME=python \ VERSION=0 \ RELEASE=1 \ ARCH=x86_64 LABEL BZComponent="$NAME" \ Name="$FGC/$NAME" \ Version="$VERSION" \ Release="$RELEASE.$DISTTAG" \ Architecture="$ARCH" \ Usage="s2i build file:///your/app 25/python your-app" \ Help="help.1" ... Dockerfile URL: https://hhorak.fedorapeople.org/python-docker/Dockerfile Other files URL: https://hhorak.fedorapeople.org/python-docker/
Today I read the guidelines again and found this sentence: "The FROM instruction must be fully-qualified with a registry name, image name, and tag as shown in this example: FROM registry.example.com/imagename:tag " It says that image tag must be there. On the other hand ":latest" is the default in Docker. So I don't know what to thing about this rule.
Correct, using :latest as it is also used in the examples: FROM registry.fedoraproject.org/f25/kubernetes-master:latest (https://fedoraproject.org/wiki/Container:Guidelines#FROM) Should be fixed now.
I also asked on #fedora-cloud and they told me, that :latest is required. Thanks, for updating it.
Actually I've realized we should probably keep the version in the name, similar as it is done for the module names, so we should eventually have python2 and python3 containers. I've changed the subject to reflect this. Tomas, does it make sense to you this way?
(In reply to Honza Horak from comment #6) > Actually I've realized we should probably keep the version in the name, > similar as it is done for the module names, so we should eventually have > python2 and python3 containers. I've changed the subject to reflect this. > > Tomas, does it make sense to you this way? Indeed it does! Food for thought: It might even be beneficial to go one step further and name it `python35`. Python minor versions (3.5 v 3.6) are not API/ABI compatible and thus instead of updating the container from python 3.5 to 3.6 it might make more sense to release a new `python36` container. However, the maintenance burden would of course be increased.
My apologies, I skimmed the Dockerfile and mistakenly assumed it was packaging the rh-python35 collection due to the openshift tag. Upon closer examination it's packaging the python3 ecosystem straight from fedora. In this case I believe the name `python3` is indeed the best choice for the container.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/python3