Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-mathutil.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-mathutil-0-0.1.git1447ad2.fc25.src.rpm Description: Supplemental utilities for Go's rand and math packages Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18354197 Packager's comments: I have removed the "mersenne" subpackage (which is unused by dependencies), because it depends on architecture-specific code (it only works on x86 arches). I increased the timeout for go tests from the default (10 minutes) to 30m to account for the "slow" armv7hl builders. This package is one of the (indirect) dependencies of syncthing.
Hello, I believe this is duplicated, reopen if I am mistaken *** This bug has been marked as a duplicate of bug 1246526 ***
Yes, this is the same package ... though the other review request is 2 years old and hasn't been touched by a human since it was opened.
github.com/remyoudompheng/bigfft [Build]Requires dependency in devel is missing. Otherwise, the rest LGTM. Can you fix the [B]R?
I removed the BR: golang(github.com/remyoudompheng/bigfft) because that go library only works on x86, and it is only needed by the "mersenne" subpackage (that nothing depends on so far; I removed it because of this). I can add a clarifying comment about this in the .spec file if you want.
Then, it should be: %ifarch x86_64 Provides: golang(%{import_path}/mersenne) = %{version}-%{release} %endif ... %ifarch x86_64 Requires: golang(github.com/remyoudompheng/bigfft) %endif ... %ifarch x86_64 BuildRequires: golang(github.com/remyoudompheng/bigfft) %endif
I put in "%if(n)arch %{ix86} x86_64 %{arm}" around the "mersenne" subpackage stuff since those are the architectures "bigfft" supports. Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-mathutil.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-mathutil-0-0.2.git1447ad2.fc25.src.rpm
Thanks for the review! You submitted a review request for the "bigfft" package 2 years ago [1], are you still interested in moving forward with it (I can do the review), or should I submit a new one (with new sources and up-to-date spec), and mark yours as a duplicate? [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1246524
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-mathutil
Fabio, feel free to close/re-submit any spec file of mine without review+ flag that is older than 3 months.
I'll keep that in mind, thanks! I just wanted to ask first - I try not to step on anyone's toes when I can.
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-73c494df6b
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-04280ba6b3
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ccdbd32f2
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ccdbd32f2
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-cznic-mathutil-0-0.2.git1447ad2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.