Red Hat Bugzilla – Bug 1431815
appliance_console_cli allows configuration that is not supported
Last modified: 2018-03-01 08:11:02 EST
Description of problem: QCI 1.1 is passing --internal without --dbdisk. This should not be allowed since it caused problems with miq_postgres_upgrade.sh Version-Release number of selected component (if applicable): 5.6 How reproducible: 100% Steps to Reproduce: 1. Setup appliance using appliance_console_cli with --internal but *not* --dbdisk 2. appliance_console 3. Examine output Actual results: Local Database Server: not initialized CFME Server: running CFME Database: localhost Database/Region: vmdb_production / 1 Expected results: Error message during appliance_console_cli Additional info: https://bugzilla.redhat.com/show_bug.cgi?id=1387672#c4 stated we shouldn't allow this configuration
I'm seeing a similar behaviour with -p: the DB password is actually mandatory to fulfil the configuration but the CLI doesn't check the parameter at the beginning and fails with an obscure error during the configuration (at a stage where recovering isn't possible anymore). In summary, the tool should properly validate all parameters before starting any modification to the system.
https://github.com/ManageIQ/manageiq-gems-pending/pull/277
https://github.com/ManageIQ/manageiq-gems-pending/pull/281
New commit detected on ManageIQ/manageiq-gems-pending/master: https://github.com/ManageIQ/manageiq-gems-pending/commit/7ae42c0221436d03a94620ce58cfabc97363f797 commit 7ae42c0221436d03a94620ce58cfabc97363f797 Author: Bo Yao <icerove@gmail.com> AuthorDate: Wed Oct 4 15:10:16 2017 -0400 Commit: Bo Yao <icerove@gmail.com> CommitDate: Fri Oct 6 11:34:51 2017 -0400 check and only allow to create database in a mount point https://bugzilla.redhat.com/show_bug.cgi?id=1431815 https://bugzilla.redhat.com/show_bug.cgi?id=1425153 .../appliance_console/internal_database_configuration.rb | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
New commit detected on ManageIQ/manageiq-gems-pending/master: https://github.com/ManageIQ/manageiq-gems-pending/commit/b74866760004f4b2b30dd75620192ed3e91e2014 commit b74866760004f4b2b30dd75620192ed3e91e2014 Author: Bo Yao <icerove@gmail.com> AuthorDate: Wed Oct 4 16:52:21 2017 -0400 Commit: Bo Yao <icerove@gmail.com> CommitDate: Fri Oct 13 15:38:58 2017 -0400 must give password to set db in cli https://bugzilla.redhat.com/show_bug.cgi?id=1431815 lib/gems/pending/appliance_console/cli.rb | 5 +++++ 1 file changed, 5 insertions(+)
Verified in 5.9.0.3
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:0380