Bug 1432104 - Review Request: rsync-bpc - A customized version of rsync that is used as part of BackupPC
Summary: Review Request: rsync-bpc - A customized version of rsync that is used as par...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-14 14:20 UTC by Richard Shaw
Modified: 2026-03-05 23:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-04-01 17:31:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Richard Shaw 2017-03-14 14:20:20 UTC
Spec URL: http://hobbes1069.fedorapeople.org//rsync-bpc.spec
SRPM URL: http://hobbes1069.fedorapeople.org//rsync-bpc-3.0.9.5-1.fc25.src.rpm

Description:
Rsync-bpc is a customized version of rsync that is used as part of
BackupPC, an open source backup system.

The main change to rsync is adding a shim layer (in the subdirectory
backuppc, and in bpc_sysCalls.c) that emulates the system calls for
accessing the file system so that rsync can directly read/write files
in BackupPC's format.

Rsync-bpc is fully line-compatible with vanilla rsync, so it can talk
to rsync servers and clients.

Rsync-bpc serves no purpose outside of BackupPC.

Comment 1 Richard Shaw 2017-03-14 14:21:45 UTC
Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18379382

Comment 2 Persona non grata 2017-03-15 09:33:14 UTC Comment hidden (spam)
Comment 3 Richard Shaw 2017-03-15 12:50:15 UTC
(In reply to Persona non grata from comment #2)
> Can you remove gcc (not needed) and fix misspellings?

Per the packaging guidelines[1] we should not assume that it will be available in the standard buildroot in the future.

Which spellings do you think need to be changed? Two of the three are intentional and while subdirectory may not be part of the standard dictionary I don't think it's wrong.

Comment 4 Persona non grata 2017-03-15 13:03:44 UTC Comment hidden (spam)
Comment 5 Persona non grata 2017-03-15 14:45:48 UTC Comment hidden (spam)
Comment 6 Richard Shaw 2017-03-15 15:15:58 UTC
(In reply to Persona non grata from comment #5)
> 
> rsync-bpc.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/rsync_bpc
> This is often a false positive, any comment?

I'm not really sure but I ran rpmlint on the rsync package and it gets the same error so I assume if it's actually a problem then once it's fixed in the rsync package it can be fixed here.


> [!]: %check is present and all tests pass.

I tried running "make check" but it fails, I don't think Craig updated the test to work with his fork.

Comment 7 Persona non grata 2017-03-15 20:40:03 UTC Comment hidden (spam)
Comment 8 Richard Shaw 2017-03-15 23:58:38 UTC
Ok, emailed backuppc-devel (more appropriate for that list) and I'll report any response.

Comment 9 Richard Shaw 2017-03-16 00:15:51 UTC
Already got a response, currently no plans to adapt the tests to work...

Comment 10 Persona non grata 2017-03-16 06:54:57 UTC Comment hidden (spam)
Comment 11 Denis Fateyev 2017-03-18 17:08:04 UTC
Packaging TODO is superfluous here, it provides Rsync project related info only. 
Please mention bundled zlib, and bring BRs list in order, e.g. as with Rsync:
 ...
 BuildRequires:	autoconf
 BuildRequires:	libacl-devel
 BuildRequires:	libattr-devel
 BuildRequires:	make
 BuildRequires:	popt-devel
Also, perl is not needed in BRs.

As for package branches, do you plan supporting it for epel7?
It would be much appreciated.

Comment 12 Richard Shaw 2017-03-19 14:04:57 UTC
(In reply to Denis Fateyev from comment #11)
> Packaging TODO is superfluous here, it provides Rsync project related info
> only. 
> Please mention bundled zlib, and bring BRs list in order, e.g. as with Rsync:
>  ...
>  BuildRequires:	autoconf
>  BuildRequires:	libacl-devel
>  BuildRequires:	libattr-devel
>  BuildRequires:	make
>  BuildRequires:	popt-devel
> Also, perl is not needed in BRs.

Mostly fixed. I don't think make is in danger of being removed from the default buildroot anytime soon...

 
> As for package branches, do you plan supporting it for epel7?
> It would be much appreciated.

Yes, and EL6 but I haven't decided if I'm going to pursue an official BackupPC4 package or just use a COPR. The BackupPC spec file is a mess and I'm struggling to get it compliant with current guidelines.

Comment 13 Denis Fateyev 2017-03-19 15:51:29 UTC
(In reply to Richard Shaw from comment #12)
> Yes, and EL6 but I haven't decided if I'm going to pursue an official
> BackupPC4 package or just use a COPR. The BackupPC spec file is a mess and
> I'm struggling to get it compliant with current guidelines.

Not sure whether providing it for EL6 makes sense. But as for epel7, there shouldn't be any issues with the package itself.

Comment 14 Gwyn Ciesla 2017-03-20 12:55:59 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rsync-bpc

Comment 15 Richard Shaw 2017-03-20 14:29:56 UTC
(In reply to Denis Fateyev from comment #13)
> (In reply to Richard Shaw from comment #12)
> > Yes, and EL6 but I haven't decided if I'm going to pursue an official
> > BackupPC4 package or just use a COPR. The BackupPC spec file is a mess and
> > I'm struggling to get it compliant with current guidelines.
> 
> Not sure whether providing it for EL6 makes sense. But as for epel7, there
> shouldn't be any issues with the package itself.

Well in either case (a backuppc4 package or COPR) it's easy enough to support since the spec already takes care of SysV init and SystemD...

Right now I'm trying to get apache to play nice with the C wrapper so the BackupPC_Admin perl script can run suid.

Comment 16 Fedora Update System 2017-03-24 15:57:13 UTC
BackupPC-XS-0.53-1.fc26 rsync-bpc-3.0.9.5-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3f27cfadc0

Comment 17 Fedora Update System 2017-03-24 15:57:30 UTC
BackupPC-XS-0.53-1.fc25 rsync-bpc-3.0.9.5-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d89031806

Comment 18 Fedora Update System 2017-03-24 15:57:45 UTC
BackupPC-XS-0.53-1.el7 rsync-bpc-3.0.9.5-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7cdafde337

Comment 19 Fedora Update System 2017-03-24 22:54:01 UTC
BackupPC-XS-0.53-1.fc26, rsync-bpc-3.0.9.5-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3f27cfadc0

Comment 20 Fedora Update System 2017-03-26 02:39:13 UTC
BackupPC-XS-0.53-1.fc25, rsync-bpc-3.0.9.5-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d89031806

Comment 21 Fedora Update System 2017-03-26 08:47:32 UTC
BackupPC-XS-0.53-1.el7, rsync-bpc-3.0.9.5-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7cdafde337

Comment 22 Fedora Update System 2017-04-01 17:31:32 UTC
BackupPC-XS-0.53-1.fc26, rsync-bpc-3.0.9.5-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2017-04-03 22:53:34 UTC
BackupPC-XS-0.53-1.fc25, rsync-bpc-3.0.9.5-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2017-04-09 23:20:03 UTC
BackupPC-XS-0.53-1.el7, rsync-bpc-3.0.9.5-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.