Bug 1432345 - Fail to install ocp3.5 on fresh hosts when set enable_excluders=false
Summary: Fail to install ocp3.5 on fresh hosts when set enable_excluders=false
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: ---
Assignee: Scott Dodson
QA Contact: liujia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-15 07:58 UTC by liujia
Modified: 2017-07-24 14:11 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2017-03-22 12:47:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0903 0 normal SHIPPED_LIVE OpenShift Container Platform atomic-openshift-utils bug fix and enhancement 2017-04-12 22:45:42 UTC

Description liujia 2017-03-15 07:58:04 UTC
Description of problem:
Trigger rpm install on fresh hosts(without any excluders) when set enable_excluders=false in inventory file, install failed and exited with following error:
TASK [openshift_excluder : Enable docker excluder] *****************************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_excluder/tasks/exclude.yml:6
.......
fatal: [openshift-178.x.x.x]: FAILED! => {
    "changed": false, 
    "cmd": "atomic-openshift-docker-excluder exclude", 
    "failed": true, 
    "invocation": {
        "module_args": {
            "_raw_params": "atomic-openshift-docker-excluder exclude", 
            "_uses_shell": false, 
            "chdir": null, 
            "creates": null, 
            "executable": null, 
            "removes": null, 
            "warn": true
        }, 
        "module_name": "command"
    }, 
    "rc": 2
}

MSG:

[Errno 2] No such file or directory


Version-Release number of selected component (if applicable):
atomic-openshift-utils-3.5.32-1.git.0.42cf266.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. prepare repos and inventory file
enable_excluders=false
2. run config.yml to install ocp3.5 on fresh hosts
# ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/config.yml -vvv | tee install.log
3. 

Actual results:
Install failed at task [Enable docker excluder].

Expected results:
Install successfully.

Additional info:

Comment 3 Scott Dodson 2017-03-15 21:53:58 UTC
Proposed fix https://github.com/openshift/openshift-ansible/pull/3673

Comment 4 Jan Chaloupka 2017-03-16 13:53:04 UTC
Liujia, what is your ansible version? Can't reproduce it within my cluster installation.

Comment 5 liujia 2017-03-17 02:13:28 UTC
atomic-openshift-master-3.5.0.52-1.git.0.844b58f.el7.x86_64.rpm

Comment 6 liujia 2017-03-17 02:13:57 UTC
atomic-openshift-3.5.0.52-1.git.0.844b58f.el7.x86_64.rpm

Comment 7 liujia 2017-03-17 05:57:31 UTC
Based on latest build, still reproduce.

# rpm -qa | grep ansible
openshift-ansible-3.5.36-1.git.0.a378c43.el7.noarch
openshift-ansible-filter-plugins-3.5.36-1.git.0.a378c43.el7.noarch
openshift-ansible-docs-3.5.36-1.git.0.a378c43.el7.noarch
openshift-ansible-callback-plugins-3.5.36-1.git.0.a378c43.el7.noarch
openshift-ansible-roles-3.5.36-1.git.0.a378c43.el7.noarch
ansible-2.2.1.0-2.el7.noarch
openshift-ansible-lookup-plugins-3.5.36-1.git.0.a378c43.el7.noarch
openshift-ansible-playbooks-3.5.36-1.git.0.a378c43.el7.noarch

Comment 9 liujia 2017-03-20 07:17:18 UTC
Version:
atomic-openshift-utils-3.5.37-1.git.0.62660e8.el7.noarch
openshift-ansible-3.5.37-1.git.0.62660e8.el7.noarch.rpm

Steps:
1. prepare repos and inventory file
enable_excluders=false
2. run config.yml to install ocp3.5 on fresh hosts
# ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/config.yml -vvv

Result:
Fail to install for the same error as description.

Add debug msg into "openshift_excluder/tasks/exclude.yml" to print {{ exclude_docker_excluder }} variable before task [Enable docker excluder]
TASK [openshift_excluder : debug] **********************************************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_excluder/tasks/exclude.yml:5
ok: [openshift-178.x.x.x] => {}

MSG:

True

It seems that some {{ exclude_docker_excluder }} was set to "True" which should be "False" in this case.

Comment 10 Scott Dodson 2017-03-21 00:15:07 UTC
https://github.com/openshift/openshift-ansible/pull/3716 fixes this

Comment 11 liujia 2017-03-21 03:05:56 UTC
Version:
atomic-openshift-utils-3.5.39-1.git.0.cb12cdb.el7.noarch

Steps:
1. prepare repos and inventory file
enable_excluders=false
2. run config.yml to install ocp3.5 on fresh hosts
# ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/config.yml -vvv

Result:
Install successfully.


Note You need to log in before you can comment on or make changes to this bug.