Bug 1432386 - static ip remain on the interface when removing non-vm network from it in case it has another vlan network attached
Summary: static ip remain on the interface when removing non-vm network from it in cas...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.19.7
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ovirt-4.1.6
: 4.19.29
Assignee: Petr Horáček
QA Contact: Michael Burman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-15 09:44 UTC by Michael Burman
Modified: 2017-09-19 10:01 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-19 10:01:56 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-4.1+
mburman: testing_plan_complete+


Attachments (Terms of Use)
Logs (824.11 KB, application/x-gzip)
2017-03-15 09:44 UTC, Michael Burman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 76937 0 master MERGED network: remove ip from a nic used by a removed network 2017-07-18 17:34:38 UTC
oVirt gerrit 80835 0 ovirt-4.1 MERGED network: remove ip from a nic used by a removed network 2017-08-23 07:33:31 UTC

Description Michael Burman 2017-03-15 09:44:05 UTC
Created attachment 1263259 [details]
Logs

Description of problem:
static ip remain on the interface when removing non-vm network from it in case it has another vlan network attached.

If attaching to an interface non-VM network + vlan network and setting a static ip on the non-vm network, the static ip is left on the interface, although the non-vm network is detached from the host.
The static ip will be removed from the interface only when detaching the vlan network from the interface. 

- If attaching only a non-vm network to the interface with static ip and then detaching the network, the static ip is removed from the interface as it should be. 

Version-Release number of selected component (if applicable):
vdsm-4.19.7-1.el7ev.x86_64

How reproducible:
100

Steps to Reproduce:
1. Attach vlan network + non-Vm network to the same interface and set static ip on the non-vm network. Approve operation in setup networks dialog 
2. Detach the non-vm network from the interface

Actual results:
The static ip remains on the interface. 

Expected results:
Static ip should be removed if the non-VM network is detached from the interface

Additional info:

Comment 1 Petr Horáček 2017-05-17 10:38:38 UTC
I managed to reproduce it with VDSM and created a test coverage for the case. Working on a fix now.

Comment 3 Dan Kenigsberg 2017-06-08 12:14:11 UTC
The patch is not yet ready, moving to next micro release.

Comment 4 Dan Kenigsberg 2017-08-07 11:50:33 UTC
A similar bug probably lurks when the ip is defined on top of a bond. If so, please file a separate bug.

Comment 5 Michael Burman 2017-08-07 12:44:16 UTC
Dan, not sure why it moved to ON_QA as it still ends up with the same result on 4.1.5.1-0.1.el7 and vdsm-4.19.26-1.el7ev.x86_64

Comment 6 Michael Burman 2017-08-27 05:03:06 UTC
Verified on - 4.1.6-0.1.el7 and vdsm-4.19.29-1.el7ev.x86_64


Note You need to log in before you can comment on or make changes to this bug.