Spec URL: https://slaanesh.fedorapeople.org/freerdp1.2.spec SRPM URL: https://slaanesh.fedorapeople.org/freerdp1.2-1.2.0-5.fc25.src.rpm Description: Free implementation of the Remote Desktop Protocol (RDP) protocol. This compatibility package only contains client libraries. Fedora Account System Username: slaanesh Note: this is a re-review of the package previously approved as both me and the reviewer missed the new packaging guidelines for compatibility libraries of November 2016: https://bugzilla.redhat.com/show_bug.cgi?id=1428383
Taking review.
1. [...] %ifarch x86_64 -DWITH_SSE2=ON \ %else -DWITH_SSE2=OFF \ %endif %ifarch armv7hl -DARM_FP_ABI=hard \ -DWITH_NEON=OFF \ %endif %ifarch armv7hnl -DARM_FP_ABI=hard \ -DWITH_NEON=ON \ %endif %ifarch armv5tel armv6l armv7l -DARM_FP_ABI=soft \ -DWITH_NEON=OFF \ %endif %ifarch aarch64 -DWITH_SSE2=OFF \ %endif [...] The last %ifarch aarch64 is redundant, as that case is already handled by %ifarch x86_64 ... %else above. 2. Redundant BuildRequires: gstreamer1-devel (pulled in by gstreamer1-plugins-base-devel) zlib-devel (pulled in by cups-devel and gstreamer1-plugins-base-devel) libX11-devel (pulled in by libXcursor-devel, libXdamage-devel, libXext-devel, libXrandr-devel and libXv-devel) libXext-devel (pulled in by libXi-devel, libXinerama-devel, libXrandr-devel and libXv-devel) No other issues, package is APPROVED. You can fix the above when importing.
(In reply to Dominik 'Rathann' Mierzejewski from comment #2) > The last %ifarch aarch64 is redundant, as that case is already handled by > %ifarch x86_64 ... %else above. > 2. Redundant BuildRequires: > gstreamer1-devel (pulled in by gstreamer1-plugins-base-devel) > zlib-devel (pulled in by cups-devel and gstreamer1-plugins-base-devel) > libX11-devel (pulled in by libXcursor-devel, libXdamage-devel, > libXext-devel, libXrandr-devel and libXv-devel) > libXext-devel (pulled in by libXi-devel, libXinerama-devel, libXrandr-devel > and libXv-devel) > No other issues, package is APPROVED. > > You can fix the above when importing. Thanks, will do. compat-freerdp12 will be retired and the current update superseded.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/freerdp1.2
freerdp-2.0.0-23.20170302git210de68.fc25 freerdp1.2-1.2.0-6.fc25 guacamole-server-0.9.11-3.fc25 remmina-1.2.0-0.32.20170302git1da1fb6.fc25 vinagre-3.22.0-4.fc25 weston-1.12.0-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7191d8e808
freerdp-2.0.0-23.20170302git210de68.fc25, freerdp1.2-1.2.0-6.fc25, guacamole-server-0.9.11-3.fc25, remmina-1.2.0-0.32.20170302git1da1fb6.fc25, vinagre-3.22.0-4.fc25, weston-1.12.0-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7191d8e808
freerdp-2.0.0-23.20170302git210de68.fc25, freerdp1.2-1.2.0-6.fc25, guacamole-server-0.9.11-3.fc25, remmina-1.2.0-0.32.20170302git1da1fb6.fc25, vinagre-3.22.0-4.fc25, weston-1.12.0-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.