Spec URL: https://drive.google.com/uc?export=download&id=0BzMS3N8RDtOIdUI0VUx2T1NEWk0 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-26-x86_64/00523278-multimc5/multimc5-0.5.1-2.fc26.src.rpm Description: MultiMC is a free, open source launcher for Minecraft. It allows you to have multiple, separate instances of Minecraft (each with their own mods, texture packs, saves, etc) and helps you manage them and their associated options with a simple interface. Fedora Account System Username:
Fedora Account System Username: srakitnican
Spec URL: https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-27-x86_64/00701080-multimc/multimc.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-27-x86_64/00701080-multimc/multimc-0.6.0-1.fc27.src.rpm * Updated to a new upstream version (0.6.0) * Renamed the package according to upstream preference * Adapted to a new upstream build target 'lin-system'
- Group: is not needed. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - This package incjudes many other licenses than Apache 2.0. Please include them all and explain the licenses breakdown in a comment: BSD (3 clause) -------------- MultiMC5-0.6.0/application/ColumnResizer.cpp MultiMC5-0.6.0/application/ColumnResizer.h MultiMC5-0.6.0/libraries/LocalPeer/include/LocalPeer.h MultiMC5-0.6.0/libraries/LocalPeer/src/LocalPeer.cpp MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile.cpp MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile.h MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile_unix.cpp MultiMC5-0.6.0/libraries/LocalPeer/src/LockedFile_win.cpp MultiMC5-0.6.0/libraries/ganalytics/LICENSE.txt GPL (v2) -------- MultiMC5-0.6.0/libraries/pack200/include/unpack200.h MultiMC5-0.6.0/libraries/pack200/src/bands.cpp MultiMC5-0.6.0/libraries/pack200/src/bands.h MultiMC5-0.6.0/libraries/pack200/src/bytes.cpp MultiMC5-0.6.0/libraries/pack200/src/bytes.h MultiMC5-0.6.0/libraries/pack200/src/coding.cpp MultiMC5-0.6.0/libraries/pack200/src/coding.h MultiMC5-0.6.0/libraries/pack200/src/constants.h MultiMC5-0.6.0/libraries/pack200/src/defines.h MultiMC5-0.6.0/libraries/pack200/src/unpack.cpp MultiMC5-0.6.0/libraries/pack200/src/unpack.h MultiMC5-0.6.0/libraries/pack200/src/unpack200.cpp MultiMC5-0.6.0/libraries/pack200/src/utils.cpp MultiMC5-0.6.0/libraries/pack200/src/utils.h MultiMC5-0.6.0/libraries/pack200/src/zip.cpp MultiMC5-0.6.0/libraries/pack200/src/zip.h GPL (v3) -------- MultiMC5-0.6.0/libraries/libnbtplusplus/COPYING.LESSER ISC --- MultiMC5-0.6.0/libraries/hoedown/LICENSE LGPL (v2 or later) ------------------ MultiMC5-0.6.0/libraries/rainbow/include/rainbow.h MultiMC5-0.6.0/libraries/rainbow/src/rainbow.cpp LGPL (v2.1 or later) -------------------- MultiMC5-0.6.0/libraries/iconfix/xdgicon.cpp MultiMC5-0.6.0/libraries/iconfix/xdgicon.h MultiMC5-0.6.0/libraries/quazip/quazip/JlCompress.cpp MultiMC5-0.6.0/libraries/quazip/quazip/JlCompress.h MultiMC5-0.6.0/libraries/quazip/quazip/quaadler32.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quaadler32.h MultiMC5-0.6.0/libraries/quazip/quazip/quachecksum32.h MultiMC5-0.6.0/libraries/quazip/quazip/quacrc32.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quacrc32.h MultiMC5-0.6.0/libraries/quazip/quazip/quagzipfile.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quagzipfile.h MultiMC5-0.6.0/libraries/quazip/quazip/quaziodevice.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quaziodevice.h MultiMC5-0.6.0/libraries/quazip/quazip/quazip.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazip.h MultiMC5-0.6.0/libraries/quazip/quazip/quazip_global.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipdir.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipdir.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipfile.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipfile.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipfileinfo.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipfileinfo.h MultiMC5-0.6.0/libraries/quazip/quazip/quazipnewinfo.cpp MultiMC5-0.6.0/libraries/quazip/quazip/quazipnewinfo.h MultiMC5-0.6.0/libraries/quazip/qztest/qztest.cpp MultiMC5-0.6.0/libraries/quazip/qztest/qztest.h MultiMC5-0.6.0/libraries/quazip/qztest/testjlcompress.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testjlcompress.h MultiMC5-0.6.0/libraries/quazip/qztest/testquachecksum32.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquachecksum32.h MultiMC5-0.6.0/libraries/quazip/qztest/testquagzipfile.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquagzipfile.h MultiMC5-0.6.0/libraries/quazip/qztest/testquaziodevice.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquaziodevice.h MultiMC5-0.6.0/libraries/quazip/qztest/testquazip.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquazip.h MultiMC5-0.6.0/libraries/quazip/qztest/testquazipdir.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquazipdir.h MultiMC5-0.6.0/libraries/quazip/qztest/testquazipfile.cpp MultiMC5-0.6.0/libraries/quazip/qztest/testquazipfile.h LGPL (v2.1 or v3) ----------------- MultiMC5-0.6.0/libraries/iconfix/internal/qiconloader.cpp MultiMC5-0.6.0/libraries/iconfix/internal/qiconloader_p.h LGPL (v2.1) ----------- MultiMC5-0.6.0/libraries/quazip/COPYING zlib/libpng ----------- MultiMC5-0.6.0/libraries/quazip/quazip/unzip.h MultiMC5-0.6.0/libraries/quazip/quazip/zip.h - Also read COPYING.md, there are other licenses, such as SIL Open Font License for fonts. - [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable Add a "Requires: hicolor-icon-theme" to own theses directories. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL (v3)", "*No copyright* CC by-sa (v3.0)", "Unknown or generated", "GPL (v2)", "BSL (v1.0)", "zlib/libpng", "ISC", "LGPL (v3 or later)", "LGPL (v2 or later)", "LGPL (v2.1)", "BSD (3 clause)", "LGPL (v2.1 or later)", "Apache (v2.0) LGPL (v3 or later)", "LGPL (v2.1 or v3)", "GPL (v2.1) LGPL (v2.1)". 851 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/multimc/review-multimc/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/ld.so.conf.d/* [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [-]: Packages are noarch unless they use JNI Note: multimc subpackage is not noarch. Please verify manually [-]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: multimc-0.6.0-1.fc28.x86_64.rpm multimc-debuginfo-0.6.0-1.fc28.x86_64.rpm multimc-debugsource-0.6.0-1.fc28.x86_64.rpm multimc-0.6.0-1.fc28.src.rpm multimc.x86_64: W: spelling-error Summary(en_US) Minecraft -> Mine craft, Mine-craft, Craftiness multimc.x86_64: W: conffile-without-noreplace-flag /etc/ld.so.conf.d/multimc-x86_64.conf multimc.x86_64: W: no-manual-page-for-binary multimc multimc-debugsource.x86_64: W: no-documentation multimc.src: W: spelling-error Summary(en_US) Minecraft -> Mine craft, Mine-craft, Craftiness 4 packages and 0 specfiles checked; 0 errors, 5 warnings.
At least "Batch" icon set contains a non-free license not acceptable by Fedora [1]. There are also other icons that are mix and matched from which some of them with an unknown license that would need to be reviewed and possibly pruned as well. Thank you for your review but I am sorry to say this seems too much work for me with not much benefit, thus I am closing this with a WONTFIX. [1] https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/message/KCKV7HWFWAY7UJH7UUQ4D2UP7AHPXE52/
To elaborate further, some of the core icons would need to be replaced unless you want the end result to look crimpled. This I feel is best done upstream and not at packaging.