Description of problem: cns-deploy does not ensure that nodes are properly labeled during cns setup If for some reason OCP infrastructure has some temporary issue when cns-deploy is ran then for some nodes cns-deploy will report error message --- /usr/bin/oc -n cnselko label nodes dhcp4-25.ocp.net storagenode=glusterfs Error from server (ServerTimeout): the server cannot complete the requested operation at this time, try again later (get nodes dhcp4-25.ocp.net) + read -r node --- Version-Release number of selected component (if applicable): cns-deploy-3.1.0-14.el7rhgs.x86_64 How reproducible: I got this issue 2x Steps to Reproduce: I do not have clear reproducer, but I think OCP temporary problems when trying to label nodes can lead to this issue. Actual results: if cns-deploy fails to label node it will proceed to next one without ensuring that nodes are actually properly labeled Expected results: cns-deploy to exit/fail if node labeling fails for any reason Additional info: na
I am not sure in which scenario #oc fails to label the node. Any way, its good to have a check before proceeding.
cns-deploy aborts if node labeling fails,
(In reply to Ramakrishna Reddy Yekulla from comment #6) > cns-deploy aborts if node labeling fails, This is not there in cns-deploy see comment#2.
The patch for the above is mentioned here upstream :: https://github.com/gluster/gluster-kubernetes/pull/220
superseded (cosmetically) by https://github.com/gluster/gluster-kubernetes/pull/223 which has been merged upstream. will get into next build.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1112