Bug 1433379 - [es_ES] [Admin Portal] Image import process message is not available for localization
Summary: [es_ES] [Admin Portal] Image import process message is not available for loca...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.0.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: ovirt-4.2.0
: ---
Assignee: Bhushan Barve
QA Contact: Bhushan Barve
URL:
Whiteboard:
Depends On: 1435402
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-17 13:53 UTC by Krishna Babu K
Modified: 2018-01-08 12:52 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-04 16:55:15 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)

Description Krishna Babu K 2017-03-17 13:53:57 UTC
Description of problem:
The UIMessage 
"Import process has begun for the image(s)\: {0}.\nYou can check import status in the main ''Events'' tab or in the ''Events'' or ''Tasks'' tabs in the footer pane."
 is not available for translation.

Version-Release number of selected component (if applicable):
4.1.1.4-0.1.el7

How reproducible:


Steps to Reproduce:
1. Log into Admin portal with es_ES locale
2. Navigate to 'Storage' Tab and select repository
3. Select an image and import

Actual results:
UIMessage is not available/marked for translation

Expected results:
UIMessage should available on zanata for translation

Additional info:
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties:importProcessHasBegunForImages=Import process has begun for the image(s)\: {0}.\nYou can check import status in the main ''Events'' tab or in the ''Events'' or ''Tasks'' tabs in the footer pane.

Comment 1 Tal Nisan 2017-03-19 09:04:48 UTC
Greg, any idea what went wrong there? It's a token message so why isn't it available for translation?

Comment 2 Greg Sheremeta 2017-03-19 22:27:33 UTC
Hmm, I'm not sure. Zanata shows only 24 messages for UIMessages, but there are 210.

wc ./frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties  
  210  2060 17771 ./frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties

@Scott, can you assist?

Comment 3 Scott Dickerson 2017-03-20 18:50:00 UTC
The update to `UIMessages.properties` was made in BZ1302562 and merged Jan 11, 2017.  The last English text push to Zanata was on Jan 5, 2017.  The push was in advance of 4.1 translation cycle 1 (BZ1415001).  Since no additional English text push to Zanata was made prior to 4.1 translation cycle 2 (BZ1415806), this key was not available to translate in cycle 2.

At this time, the new keys will be pushed to Zanata for translation in advance of the translation cycles for ovirt-4.2.

Currently in Zanata (for example, for the french translations [1]), there are 197 translatable messages.  In the `UIMessages.properties` file on ovirt-4.1 branch, there are 204 keys.  The extra 7 keys were all merged after Jan 5.


[1] - https://translate.zanata.org/webtrans/translate?project=ovirt&iteration=ovirt-4.1&localeId=fr&locale=en-US#doc:frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages

[2] - from command: `sed -e '/\s*#.*$/d' -e '/^\s*$/d' ./frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties | wc`

Comment 4 Scott Dickerson 2017-03-21 21:40:39 UTC
I can verify that translations for this change have not been made in 4.1 and are not currently available on the ovirt-4.1 version of the zanata project [1].  The gritty details are in comment 3.  The strings will be available for translation, and will be translated in the 4.2 translation cycle.  This hasn't been scheduled yet.

Unless there is a critical need to verify that translations are available and have been made for this bug, it can be closed normally.  Translations will be performed and verified in the 4.2 translation cycle.


[1] - https://translate.zanata.org/iteration/view/ovirt/ovirt-4.1

Comment 5 Scott Dickerson 2017-03-23 17:56:27 UTC
This bug has been made dependent on the first translation cycle of oVrit 4.2 - BZ1435402.  Once that translation cycle is complete, and the translations have been merged to gerrit, this bug can be tested appropriately.

Comment 6 Oved Ourfali 2017-11-01 07:51:43 UTC
Translations are merged.
Moving to MODIFIED.

Comment 7 Greg Sheremeta 2017-12-30 13:39:57 UTC
@Bhushan -- please retest and verify / close currentrelease, or fail if needed.


Note You need to log in before you can comment on or make changes to this bug.