Bug 1433408 - [RFE] Upgrade to latest checkstyle
Summary: [RFE] Upgrade to latest checkstyle
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Build.Maven
Version: future
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Allon Mureinik
QA Contact: Allon Mureinik
URL:
Whiteboard:
: 1363772 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-17 15:22 UTC by Sandro Bonazzola
Modified: 2017-12-06 17:02 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-17 08:41:15 UTC
oVirt Team: Infra
Embargoed:
amureini: ovirt-4.2?
lsvaty: testing_plan_complete-
rule-engine: planning_ack?
mperina: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 74424 0 master MERGED core: Tests import order 2017-03-22 11:54:59 UTC
oVirt gerrit 74425 0 master MERGED core: AffinityRulesUtils lambda's left curly 2017-03-22 11:55:06 UTC
oVirt gerrit 74426 0 master MERGED webadmin: EventProvidingCollection left curly 2017-03-22 11:54:56 UTC
oVirt gerrit 74427 0 master MERGED engine: double semicolons 2017-03-22 11:54:53 UTC
oVirt gerrit 74428 0 master MERGED restapi: Test anonymous extensions 2017-03-22 11:55:02 UTC
oVirt gerrit 74429 0 master MERGED build: Upgrade checkstyle version 2017-03-22 21:26:54 UTC
oVirt gerrit 74430 0 master MERGED build: Extend AbstractCheck instead of Check 2017-03-22 21:26:49 UTC

Description Sandro Bonazzola 2017-03-17 15:22:12 UTC 
ovirt-engine is currently using checkstyle 6.8.
Fedora 25 ships checkstyle 7.1.
Fedora 26 ships checkstyle 7.5.1.

Consider updating to latest available checkstyle.
Comment 1 Martin Perina 2017-03-17 20:03:29 UTC 
*** Bug 1363772 has been marked as a duplicate of this bug. ***
Comment 2 Allon Mureinik 2017-03-21 15:50:37 UTC 
We're using a pretty old version of Checkstyle (6.8).

This doesn't mean, of course, we can't upgrade, but it would take some meticulous work, as they don't guarantee backwards compatibility between major versions.
Comment 3 Pavel Stehlik 2017-07-17 08:32:57 UTC 
CodeChange - nothing for QE, P.
Comment 4 Allon Mureinik 2017-07-17 08:40:29 UTC 
Patch was merged and build passes.
"Offending" patches are failed by CI in jenkins.
CLOSING.
Note You need to log in before you can comment on or make changes to this bug.