Bug 1433628 - First line of pixels chopped off in Chromium/Chrome when liberation-fonts built with fontforge > 20150430
Summary: First line of pixels chopped off in Chromium/Chrome when liberation-fonts bui...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: liberation-fonts
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pravin Satpute
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-18 23:01 UTC by Andrew Gunnerson
Modified: 2017-12-28 18:06 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-28 18:06:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Andrew Gunnerson 2017-03-18 23:01:58 UTC
Description of problem:

The current liberation-fonts package is built by fontforge 20160404 and results in the top of the fonts being chopped off in some pages in Chrome/Chromium.

For example, with this page: https://www.reddit.com/r/linux/comments/600h4f/wine_24_released/

When built with fontforge 20160404: http://i.imgur.com/kO2H3Hw.png
When built with fontforge 20150430: http://i.imgur.com/IQmu5o3.png

Notice how the first line of pixels is getting chopped off.


Version-Release number of selected component (if applicable):

liberation-fonts-common-1.07.4-7.fc24.noarch
liberation-mono-fonts-1.07.4-7.fc24.noarch
liberation-sans-fonts-1.07.4-7.fc24.noarch
liberation-serif-fonts-1.07.4-7.fc24.noarch
fontforge-20160404-5.fc25.x86_64


Additional info:

I did a git bisect and found that this is the commit in fontforge that introduced the issue.

---
[chenxiaolong@cxl-fedora25vm fontforge]$ git bisect bad
e870019c2602d50eb00793e979f3e11bcc71d6cf is the first bad commit
commit e870019c2602d50eb00793e979f3e11bcc71d6cf
Author: Frédéric Wang <fred.wang>
Date:   Wed May 13 08:03:13 2015 +0200

    Fix read/write of bits USE_TYPO_METRICS and WWS for OS2 version < 4

:040000 040000 7032ea971c1d084ab8a038b4a80d9092e53a8519 eb11e4b5a69718ad94d8dbfc414e7b2a944548d3 M	fontforge
---

https://github.com/fontforge/fontforge/commit/e870019c2602d50eb00793e979f3e11bcc71d6cf

Is this something that can be fixed without affecting/breaking other fonts?

Comment 1 Andrew Gunnerson 2017-03-18 23:03:51 UTC
By the way, my screenshots are of the proprietary Google Chrome, but the same behavior occurs with Chromium from the Fedora repos (56.0.2924.87-3.fc25.x86_64).

Comment 2 Andrew Gunnerson 2017-03-18 23:03:52 UTC
By the way, my screenshots are of the proprietary Google Chrome, but the same behavior occurs with Chromium from the Fedora repos (56.0.2924.87-3.fc25.x86_64).

Comment 3 Pravin Satpute 2017-03-24 06:00:29 UTC
Can you report this issue on upstream fontforge as well?  https://github.com/fontforge/fontforge/issues/

Lets see whats upstream says about it.

Comment 4 Andrew Gunnerson 2017-03-24 11:31:58 UTC
Absolutely. I'll make the upstream bug report after work and link it here.

Comment 5 Andrew Gunnerson 2017-03-24 23:42:16 UTC
I have reported the issue upstream here: https://github.com/fontforge/fontforge/issues/3052

Comment 6 Jan Niklas Hasse 2017-07-12 13:18:38 UTC
You can also notice this bug when marking / selecting those fonts in Firefox.

Comment 7 Fedora End Of Life 2017-11-16 18:39:04 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 8 Andrew Gunnerson 2017-11-20 19:13:17 UTC
I changed the target version to 27 since this still affects the latest Fedora release.

Comment 9 Jens Petersen 2017-11-21 10:14:52 UTC
Could you confirm if this still happens with fontforge-20170731?

Comment 10 Andrew Gunnerson 2017-11-24 01:09:23 UTC
Thank you for the reply, Jens. I just recompiled the liberation-fonts RPMs against fontforge-20170731-2.fc27.x86_64 and it seems the issue still exists.

When visiting the following page: https://www.reddit.com/r/rust/comments/7ew6a6/announcing_rust_122_and_1221/

with either of the following browsers:
* chromium-62.0.3202.89-1.fc27.x86_64
* google-chrome-stable-62.0.3202.94-1.x86_64

I get the following results:

* Built against fontforge 20170731: https://i.imgur.com/koJXJzn.png
* Built against fontforge 20150430: https://i.imgur.com/UhRZNv4.png

(The missing line of pixels is most noticeable around the "49 points" text.)

Comment 11 Andrew Gunnerson 2017-12-04 05:06:55 UTC
This seems to be reproducible on my new laptop with a 4K screen. At GNOME's default 2x scale factor, the top 2 rows of pixels are chopped off instead of just the top row.

On the HiDPI screen, it's no longer easily noticeable, but the issue is definitely still there.

I've made a side-by-side comparison screenshot with the two fontforge versions: https://i.imgur.com/vW5L0K3.png

Comment 12 Andrew Gunnerson 2017-12-28 18:06:40 UTC
This was finally fixed by https://bugzilla.redhat.com/show_bug.cgi?id=1526510 (version 1.07.4-10.fc27.noarch).


Note You need to log in before you can comment on or make changes to this bug.