Description of problem: Sushy is a Python library to communicate with Redfish based systems (http://www.dmtf.org/standards/redfish) which is currently being used to create a "redfish" driver/hardware type for Ironic. Additional info: The official repository for the project is the https://github.com/openstack/sushy
SPEC: https://raw.githubusercontent.com/umago/sushy-spec/master/python-sushy.spec SRPM: https://github.com/umago/sushy-spec/raw/master/python-sushy-0.0.1-0.20170320120824.39f9db1.el7.centos.src.rpm Upstream repository: https://github.com/openstack/sushy
The rdoinfo change: https://review.rdoproject.org/r/#/c/5897/
Initial license check looks good, project is Apache v2.0 licensed: sushy/.coveragerc: *No copyright* UNKNOWN sushy/.gitreview: *No copyright* UNKNOWN sushy/.mailmap: *No copyright* UNKNOWN sushy/.testr.conf: *No copyright* UNKNOWN sushy/CONTRIBUTING.rst: *No copyright* UNKNOWN sushy/HACKING.rst: *No copyright* UNKNOWN sushy/LICENSE: *No copyright* Apache (v2.0) sushy/MANIFEST.in: *No copyright* UNKNOWN sushy/README.rst: *No copyright* Apache sushy/babel.cfg: *No copyright* UNKNOWN sushy/requirements.txt: *No copyright* UNKNOWN sushy/setup.cfg: *No copyright* Apache sushy/setup.py: Apache (v2.0) GENERATED FILE sushy/test-requirements.txt: *No copyright* UNKNOWN sushy/tox.ini: *No copyright* UNKNOWN sushy/sushy/__init__.py: *No copyright* Apache (v2.0) sushy/sushy/connector.py: Apache (v2.0) sushy/sushy/exceptions.py: Apache (v2.0) sushy/sushy/main.py: Apache (v2.0) sushy/sushy/utils.py: Apache (v2.0) sushy/tools/mockup_server.py: Apache (v2.0) sushy/doc/source/conf.py: *No copyright* Apache (v2.0) sushy/doc/source/contributing.rst: *No copyright* UNKNOWN sushy/doc/source/index.rst: *No copyright* UNKNOWN sushy/doc/source/installation.rst: *No copyright* UNKNOWN sushy/doc/source/readme.rst: *No copyright* UNKNOWN sushy/doc/source/usage.rst: *No copyright* UNKNOWN sushy/releasenotes/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE sushy/releasenotes/source/index.rst: *No copyright* UNKNOWN sushy/releasenotes/source/unreleased.rst: *No copyright* UNKNOWN sushy/sushy/resources/base.py: Apache (v2.0) sushy/tools/mockup_server_libvirt/mockup_server_libvirt.py: Apache (v2.0) sushy/tools/mockup_server_libvirt/requirements.txt: *No copyright* UNKNOWN sushy/sushy/resources/system/constants.py: Apache (v2.0) sushy/sushy/resources/system/mappings.py: Apache (v2.0) sushy/sushy/resources/system/system.py: Apache (v2.0) sushy/sushy/tests/unit/base.py: Apache (v2.0) sushy/sushy/tests/unit/test_connector.py: Apache (v2.0) sushy/sushy/tests/unit/test_main.py: Apache (v2.0) sushy/sushy/tests/unit/test_utils.py: Apache (v2.0) sushy/tools/mockup_server_libvirt/templates/root.json: UNKNOWN sushy/tools/mockup_server_libvirt/templates/system.json: *No copyright* UNKNOWN sushy/tools/mockup_server_libvirt/templates/system_collection.json: UNKNOWN sushy/sushy/tests/unit/json_samples/root.json: UNKNOWN sushy/sushy/tests/unit/json_samples/system.json: *No copyright* UNKNOWN sushy/sushy/tests/unit/json_samples/system_collection.json: UNKNOWN sushy/sushy/tests/unit/resources/test_base.py: Apache (v2.0) sushy/sushy/tests/unit/resources/system/test_system.py: Apache (v2.0)
LGTM but please set min versions for pbr and six to 2.0.0 and 1.9.0
> LGTM but please set min versions for pbr and six to 2.0.0 and 1.9.0 Hi Haikel, Done! Here's the files: SPEC: https://raw.githubusercontent.com/umago/sushy-spec/master/python-sushy.spec SRPM: https://github.com/umago/sushy-spec/raw/master/python-sushy-0.0.1-0.20170322101819.39f9db1.el7.centos.src.rpm(In reply to Haïkel Guémar from comment #4)
Ouch, sorry messeup with the copy & paste, SRPM: https://github.com/umago/sushy-spec/raw/master/python-sushy-0.0.1-0.20170322101819.39f9db1.el7.centos.src.rpm
I would expect something like %if 0%{?fedora} %global with_python3 1 %endif on top of the spec file. Otherwise looks good to me.
Thanks for the review @Matthias, Here's the new files: SPEC: https://raw.githubusercontent.com/umago/sushy-spec/master/python-sushy.spec SRPM: https://github.com/umago/sushy-spec/raw/master/python-sushy-0.0.1-0.20170327134220.392a4a6.el7.centos.src.rpm
Sorry for nitpicking here, I couldn't find any reference, why this requires shadow-utils. There is no pre-section in the spec. While you're at it, please change references to python-pbr etc. to be using python2-pbr (and other python2 packages as well). I'd doubt, this package requires python3-git, if it doesn't require python2-git as well. It looks like git is required at compile time for pbr? Then there's no need for python[23]-git.
Thanks for the review Matthias, Here's the new one: SPEC: https://raw.githubusercontent.com/umago/sushy-spec/master/python-sushy.spec SRPM: https://github.com/umago/sushy-spec/raw/master/python-sushy-0.0.1-0.20170405102839.392a4a6.el7.centos.src.rpm
Lucas, this one looks good to me now. The source is ASL 2.0 licensed. You can go ahead now and import it into RDO. Thanks for your patience.
Gerrit-reviewed files (for the fedora-review report): - Spec: https://raw.githubusercontent.com/rdo-packages/sushy-distgit/rpm-master/python-sushy.spec - SRPM: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/69/6169/5/gate/DLRN-rpmbuild/Za37e852e6ae948539b96b3014242534e/artifacts/centos/repos/39/2a/392a4a62726ef76a621c750adf3140b0664d3059_dev/python-sushy-0.0.1-0.20170407103009.392a4a6.el7.centos.src.rpm
Matthias, hi! Do you plan on finishing the formal review? According to apevec there is some output from some tool missing.
Is there a written documentation to require fedora-review output? Due to version specifics for rdo (xxx instead of a real version), rdo packages don't build in koji directly. In my understanding, we should explicitly look at the licenses, which are fine here.
Haikel, can you publish Mock configs using RDO Trunk repos which can be used with fedora-review tool? Matthias, fedorea-review integration with review.rdoproject.org is planned, in the meantime formal review is nice to have as it makes further reviews down the productization line easier.