Bug 1433925 - poolmetadatasize for the thinpool created on arbiter node should not be 16GB
Summary: poolmetadatasize for the thinpool created on arbiter node should not be 16GB
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Gdeploy
Version: 0.10.7-0.0.15
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.1.5
: ---
Assignee: Devyani Kota
QA Contact: RamaKasturi
URL:
Whiteboard:
Depends On:
Blocks: Gluster-HC-3 1447919
TreeView+ depends on / blocked
 
Reported: 2017-03-20 11:52 UTC by RamaKasturi
Modified: 2017-08-23 08:00 UTC (History)
5 users (show)

Fixed In Version: cockpit-ovirt-0.10.7-0.0.21
Clone Of:
Environment:
Last Closed: 2017-08-23 08:00:59 UTC
oVirt Team: Gluster
Embargoed:
sabose: ovirt-4.1?
sabose: planning_ack?
rule-engine: devel_ack+
knarra: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 74486 0 master MERGED gdeploy: calculate thinpoolMetadata size dynamically. 2017-04-19 12:40:53 UTC
oVirt gerrit 75651 0 ovirt-4.1 MERGED gdeploy: calculate thinpoolMetadata size dynamically. 2017-04-20 12:18:46 UTC
oVirt gerrit 78215 0 master MERGED gdeploy: re-calculate thinpoolMetadata size dynamically. 2017-07-05 18:34:50 UTC
oVirt gerrit 78232 0 ovirt-4.1 MERGED gdeploy: re-calculate thinpoolMetadata size dynamically. 2017-07-05 18:34:39 UTC

Description RamaKasturi 2017-03-20 11:52:28 UTC
Description of problem:
poolmetadatasize  for the thinpool created on arbiter node is 16GB. Here thinpool size on the arbiter node is only 20GB and poolmetadatasize cannot be set as 16GB. poolmetadatasize should  be 0.5% of thinpool size.

Version-Release number of selected component (if applicable):
cockpit-ovirt-dashboard-0.10.7-0.0.15.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Install latest RHVH ISO
2. start deploying gluster on the nodes
3. provide all the values and generate gdeployConfig file

Actual results:
In the config file user can see that thinpool size on the arbiter node is only 20GB, but poolmetadatasize is set as 16GB.

Expected results:
poolmetadatasize should be set as 0.5% of thinpool size.

Additional info:

Comment 1 RamaKasturi 2017-05-22 12:08:22 UTC
Hi devyani,

   I am trying to verify this bug. I have installed latest ovirt-cockpit-dashboard and i have few queries on the same and could you please clarify the below  ?

1) I see that thinpool size on arbiter node is 44GB? How did we arrive at this?
2) poolmetadatasize should be 0.5% of thinpool. 0.5% of 44 GB is 220MB. But in the gdeployconfig.conf file i see it as 1GB.

Comment 2 Devyani Kota 2017-05-22 14:18:21 UTC
Hi Kasturi,
Not the best practice, but I think that the patches to both the
following bugs: [1] [2] are related, considering the fact that
changes are made to the same file.
Thinpool size should be returning 16GB.
Yes, poolmetadatasize should be 0.5% of thinpool.
Testing after implementing both patches should help?
Please let me know if it doesn't. Thanks.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1434735
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1433925

Comment 3 RamaKasturi 2017-05-23 07:02:03 UTC
Hi devyani,

    I see that poolmetadatasize for thinpool created on arbiter node is set as 1gb irrespective of the thinpoolsize. Is this the expected behaviour?, can you please confirm ?

When thinpool size was 44GB, poolmetadatasize was 1GB.

When thinpool size is 40GB, poolmetadatasize is set as 1GB.

Comment 4 RamaKasturi 2017-05-23 09:17:17 UTC
Moving this back as i see that when allocating size for thinpool, poolmetadatasize is not taken into account.

Here i see that thinpool size does not include poolmetadatasize.

Comment 5 Red Hat Bugzilla Rules Engine 2017-05-23 09:17:22 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 7 Sahina Bose 2017-07-10 14:23:27 UTC
(In reply to RamaKasturi from comment #3)
> Hi devyani,
> 
>     I see that poolmetadatasize for thinpool created on arbiter node is set
> as 1gb irrespective of the thinpoolsize. Is this the expected behaviour?,
> can you please confirm ?
> 
> When thinpool size was 44GB, poolmetadatasize was 1GB.
> 
> When thinpool size is 40GB, poolmetadatasize is set as 1GB.

The poolmetadatasize is rounded up to nearest GB as per the code. So this is as expected.

Kasturi, is the thinpoolsize then the only issue with this bug?

Comment 8 RamaKasturi 2017-07-11 09:35:35 UTC
If you say poolmetadatasize  is rounded to nearest GB then only thinpoolsize is the issue with this bug.

Comment 9 RamaKasturi 2017-07-24 09:16:24 UTC
Verified and works fine with build cockpit-ovirt-dashboard-0.10.7-0.0.21.el7ev.noarch.

Thinpoolsize on the arbiter node is rounded off to nearest GB which is 1GB. 

Since this bug is moved to on_qa will raise another bug to include poolmetadatasize with thinpoolsize.

Comment 10 RamaKasturi 2017-07-24 09:26:10 UTC
Logged another bug for the inclusion of poolmetadatasize with thinpool.

https://bugzilla.redhat.com/show_bug.cgi?id=1474267


Note You need to log in before you can comment on or make changes to this bug.