Spec URL: https://kalev.fedorapeople.org/tilix.spec SRPM URL: http://kalev.fedorapeople.org/tilix-1.5.4-1.fc26.src.rpm Description: Tilix is a tiling terminal emulator with the following features: - Layout terminals in any fashion by splitting them horizontally or vertically - Terminals can be re-arranged using drag and drop both within and between windows - Terminals can be detached into a new window via drag and drop - Input can be synchronized between terminals so commands typed in one terminal are replicated to the others - The grouping of terminals can be saved and loaded from disk - Terminals support custom titles - Color schemes are stored in files and custom color schemes can be created by simply creating a new file - Transparent background - Supports notifications when processes are completed out of view The application was written using GTK 3 and an effort was made to conform to GNOME Human Interface Guidelines (HIG). Fedora Account System Username: kalev Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18489998
* Mon Mar 20 2017 Kalev Lember <klember> - 1.5.4-2 - Use _d_optflags and disable debug print to stderr Spec URL: https://kalev.fedorapeople.org/tilix.spec SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-1.fc26.src.rpm
I'm the author of Tilix and I've subscribed to this. If there are any questions or issues that need resolving in the application to make this happen just let me know.
Taking this review.
@Kalev, Your SRPM and spec don't match.
Sorry, I typoed the SRPM link above. Spec URL: https://kalev.fedorapeople.org/tilix.spec SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-2.fc26.src.rpm
Created attachment 1264822 [details] licensecheck output for tilix Some issues encountered by fedora-review: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "*No copyright* CC by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL (v2.0)", "MPL (v2.0)". 126 files have unknown license. Detailed output of licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt Please verify with upstream that the licensing is sane. licensecheck output attached to this bug. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/metainfo Until we migrate from /usr/share/appdata to /usr/share/metainfo completely (tooling, dependency generators, etc.), please move metainfo/appdata files to /usr/share/appdata. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo, /usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22, /usr/share/glib-2.0, /usr/share/icons/hicolor/512x512, /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The dbus dir ownership can be fixed with Req on dbus, I believe. The glib-2.0 dirs issue can probably be fixed by Req glib2, though that should be happening already...
(In reply to Neal Gompa from comment #6) > Created attachment 1264822 [details] > licensecheck output for tilix > > Some issues encountered by fedora-review: > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "GPL (v2 or later)", "GPL (v3 or later)", "*No copyright* CC > by-sa (v3.0)", "Unknown or generated", "*No copyright* MPL (v2.0)", > "MPL (v2.0)". 126 files have unknown license. Detailed output of > licensecheck in /home/makerpm/1434003-tilix/licensecheck.txt > > Please verify with upstream that the licensing is sane. licensecheck output > attached to this bug. Thanks. I've updated the licensing breakdown, which now reads: # The tilix source code is MPLv2.0, # source/gx/gtk/x11.d is GPLv2+, # source/secret is LGPLv3+, # source/x11 and com.gexperts.Tilix.gschema.xml are GPLv3+, # icons are CC-BY-SA. # This makes the combined license: License: MPLv2.0 and GPLv3+ and CC-BY-SA > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/metainfo > > Until we migrate from /usr/share/appdata to /usr/share/metainfo completely > (tooling, dependency generators, etc.), please move metainfo/appdata files > to /usr/share/appdata. Putting appdata files in that directory is completely fine. I just recently fixed the appstream generator to work with /usr/share/metainfo. As for the directory ownership, this belongs to the filesystem package. I've already filed a filesystem ticket earlier today to add it, https://bugzilla.redhat.com/show_bug.cgi?id=1434008 > [!]: Package must own all directories that it creates. > Note: Directories without known owners: > /usr/share/icons/hicolor/22x22/apps, > /usr/share/icons/hicolor/32x32/apps, /usr/share/metainfo, > /usr/share/dbus-1/services, /usr/share/icons/hicolor/24x24, > /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/16x16, > /usr/share/icons/hicolor/48x48/apps, > /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, > /usr/share/icons/hicolor/24x24/apps, /usr/share/dbus-1, > /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/32x32, > /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22, > /usr/share/glib-2.0, /usr/share/icons/hicolor/512x512, > /usr/share/glib-2.0/schemas, /usr/share/icons/hicolor/48x48, > /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable > > The hicolor dir ownership can be fixed with Req on hicolor-icon-theme. The > dbus dir ownership can be fixed with Req on dbus, I believe. The glib-2.0 > dirs issue can probably be fixed by Req glib2, though that should be > happening already... Thanks, I've added explicit dbus and hicolor-icon-theme deps. glib2 is definitely pulled in via dependencies and there's no need to add it. * Mon Mar 20 2017 Kalev Lember <klember> - 1.5.4-3 - Update licensing breakdown (#1434003) - Add explicit dbus and hicolor-icon-theme deps for directory ownership Spec URL: https://kalev.fedorapeople.org/tilix.spec SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-3.fc26.src.rpm
Can you get upstream to include license files for all licenses that the project is covered under?
Probably, but this shouldn't be a blocker for the package review.
I've updated the spec file to make sure all the license files that upstream ships are included. * Mon Mar 20 2017 Kalev Lember <klember> - 1.5.4-4 - Include data/icons/LICENSE and source/x11/LICENSE as %%license (#1434003) Spec URL: https://kalev.fedorapeople.org/tilix.spec SRPM URL: https://kalev.fedorapeople.org/tilix-1.5.4-4.fc26.src.rpm
Actually, it appears that glib2 isn't pulled in by *any* dependencies, so it needs to be added as a Requires. It's also needed to ensure the file trigger fires.
It most definitely gets pulled in. Something like tilix->gtkd->gtk3->glib2 dep chain or so.
Hmm, if you're sure... Aside from this and the metainfo thing, fedora-review and rpmlint are happy, so... PACKAGE APPROVED.
Excellent. Thank you for the quick review, Neal!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/tilix
tilix-1.5.4-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e32be8694
tilix-1.5.4-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2e32be8694
tilix-1.5.4-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.