Bug 1434127 - Review Request: dehydrated - A client for signing certificates with an ACME server
Summary: Review Request: dehydrated - A client for signing certificates with an ACME s...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrick Uiterwijk
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-20 19:08 UTC by Paul Wouters
Modified: 2017-04-06 23:48 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-01 17:23:34 UTC
Type: ---
Embargoed:
puiterwijk: fedora-review+


Attachments (Terms of Use)

Description Paul Wouters 2017-03-20 19:08:11 UTC
Spec URL: https://nohats.ca/ftp/dehydrated/dehydrated.spec
SRPM URL: https://nohats.ca/ftp/dehydrated/dehydrated-0.4.0-4.el7.centos.src.rpm
Description: A client for signing certificates with an ACME server
Fedora Account System Username: pwouters

Comment 1 Patrick Uiterwijk 2017-03-20 20:50:14 UTC
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
X License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
8114ba0144a158d5ad1bdf02e6f43195  v0.4.0
8114ba0144a158d5ad1bdf02e6f43195  srpm/dehydrated-0.4.0.tar.gz
+ Package needs ExcludeArch
+ BuildRequires correct
X Package has %defattr and permissions on files is good.
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
    Fine:
    dehydrated.src: W: spelling-error %description -l en_US openssl -> slope
    dehydrated.src: W: spelling-error %description -l en_US subdomains -> sub domains, sub-domains, domains
    dehydrated.noarch: W: spelling-error %description -l en_US subdomains -> sub domains, sub-domains, domains
    dehydrated.noarch: W: only-non-binary-in-usr-lib
    dehydrated.noarch: E: non-standard-executable-perm /etc/dehydrated/hook.sh 750
    dehydrated.noarch: E: wrong-script-interpreter /etc/dehydrated/hook.sh /usr/bin/env bash
    dehydrated.noarch: W: non-ghost-in-run /run/dehydrated
    dehydrated.noarch: E: non-standard-dir-perm /run/dehydrated 750
    dehydrated.noarch: E: wrong-script-interpreter /usr/bin/dehydrated /usr/bin/env bash
    dehydrated.noarch: E: wrong-script-interpreter /usr/share/doc/dehydrated/examples/hook.sh /usr/bin/env bash
    dehydrated.noarch: W: no-manual-page-for-binary dehydrated

    Understandable:
    dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated 750
    dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/accounts 750
    dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/archive 750
    dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/certs 750
    dehydrated.noarch: E: non-standard-dir-perm /etc/dehydrated/conf.d 750

    Possibly wrong:
    dehydrated.noarch: E: non-readable /etc/dehydrated/conf.d/local.sh 640
    dehydrated.noarch: E: non-readable /etc/dehydrated/config 640
    dehydrated.noarch: E: non-readable /etc/dehydrated/domains.txt 640
    dehydrated.noarch: E: non-readable /etc/dehydrated/hook.sh 750


+ final provides and requires are sane:
    Provides:
    config(dehydrated) = 0.4.0-4.fc27
    dehydrated = 0.4.0-4.fc27

    Requires:
    /bin/sh
    /usr/bin/env
    config(dehydrated) = 0.4.0-4.fc27
    curl
    openssl


SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
+ Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version

Issues:

1. License file included in package
2. Package has %defattr and permissions on files is good. - Some of the permissions are strange

Comment 2 Patrick Uiterwijk 2017-03-20 20:53:48 UTC
Please add the %license file before import and please check file permissions.

No serious issues, so APPROVED.

Comment 3 Patrick Uiterwijk 2017-03-20 20:57:52 UTC
I had the bitmask wrong inside my head, and thought that 1=read, but 4=read and 1=execute. File permissions look good to me.

Comment 4 Gwyn Ciesla 2017-03-20 21:52:14 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dehydrated

Comment 5 Fedora Update System 2017-03-21 14:24:47 UTC
dehydrated-0.4.0-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b8c10b47f

Comment 6 Fedora Update System 2017-03-21 14:25:43 UTC
dehydrated-0.4.0-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-05b324c3b0

Comment 7 Fedora Update System 2017-03-21 14:26:25 UTC
dehydrated-0.4.0-5.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3f7d6b1a42

Comment 8 Fedora Update System 2017-03-21 16:26:59 UTC
dehydrated-0.4.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7feb777383

Comment 9 Fedora Update System 2017-03-22 00:53:21 UTC
dehydrated-0.4.0-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b8c10b47f

Comment 10 Fedora Update System 2017-03-22 15:27:07 UTC
dehydrated-0.4.0-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-05b324c3b0

Comment 11 Fedora Update System 2017-03-23 01:49:18 UTC
dehydrated-0.4.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7feb777383

Comment 12 Fedora Update System 2017-03-23 01:49:55 UTC
dehydrated-0.4.0-5.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-3f7d6b1a42

Comment 13 Fedora Update System 2017-04-01 17:23:34 UTC
dehydrated-0.4.0-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-04-03 22:53:06 UTC
dehydrated-0.4.0-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-04-06 23:46:43 UTC
dehydrated-0.4.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2017-04-06 23:48:53 UTC
dehydrated-0.4.0-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.