Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-AudriusButkevicius-pfilter.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-AudriusButkevicius-pfilter-0-0.1.git09b3cfd.fc25.src.rpm Description: Simple Packet Filtering package written in Go Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18505741 PS: The tests and unit test subpackage are disabled because there are no "*_test.go" files. This package is one of the (new) dependencies of syncthing 0.14.25.
Hello Fabio, I am taking this one. - The conditional statement on line 29 seems to be duplicated. - There's no test suite available for the package. The macro with all the unit-tests subpackage entries is disabled. You may want to consider cleaning the duplications. The package looks good. Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-AudriusButkevicius-pfilter-devel-0-0.1.git09b3cfd.fc27.noarch.rpm golang-github-AudriusButkevicius-pfilter-0-0.1.git09b3cfd.fc27.src.rpm golang-github-AudriusButkevicius-pfilter-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory golang-github-AudriusButkevicius-pfilter-devel.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- golang-github-AudriusButkevicius-pfilter-devel (rpmlib, GLIBC filtered): Provides -------- golang-github-AudriusButkevicius-pfilter-devel: golang(github.com/AudriusButkevicius/pfilter) golang-github-AudriusButkevicius-pfilter-devel Source checksums ---------------- https://github.com/AudriusButkevicius/pfilter/archive/09b3cfdd04de89f0196caecb0b335d7149a6593a/AudriusButkevicius-pfilter-09b3cfd.tar.gz : CHECKSUM(SHA256) this package : 4d03ab22f3c946d5ef7f4fd332a4bc4314029333aacb3eedb8ca4bb19b3ae9dd CHECKSUM(SHA256) upstream package : 4d03ab22f3c946d5ef7f4fd332a4bc4314029333aacb3eedb8ca4bb19b3ae9dd
Also, consider changing the revision tag with the new guidelines, including the date the snapshot was taken. Sorry for the spam :)
Thanks for the review, I've already incorporated fixes for the issues you've pointed out in the linked .spec file. I will leave the unit test-specific parts of the .spec file (even though they are disabled), since it's easier to enable unit tests that way if upstream decides to add some in the future.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-AudriusButkevicius-pfilter
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b67dfff19
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5cea2dc37b
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a0940eda30
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5cea2dc37b
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b67dfff19
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a0940eda30
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.