Bug 1434449 - Review Request: perl-Dist-Zilla-Plugin-CheckChangesHasContent - Ensure Changes file has content before releasing
Summary: Review Request: perl-Dist-Zilla-Plugin-CheckChangesHasContent - Ensure Change...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-21 14:16 UTC by Petr Pisar
Modified: 2017-03-22 15:00 UTC (History)
2 users (show)

Fixed In Version: perl-Dist-Zilla-Plugin-CheckChangesHasContent-0.010-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-22 15:00:53 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-21 14:16:57 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-CheckChangesHasContent/perl-Dist-Zilla-Plugin-CheckChangesHasContent.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-CheckChangesHasContent/perl-Dist-Zilla-Plugin-CheckChangesHasContent-0.010-1.fc27.src.rpm
Description:
This is a "before release" Dist::Zilla plugin that ensures that your
Changes file actually has some content since the last release. If it
doesn't find any, it will abort the release process.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-21 16:26:10 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Dist-Zilla-Plugin-CheckChangesHasContent-0.010-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Data::Section) >= 0.200002
      1 perl(Dist::Zilla) >= 2.100950
      1 perl(Dist::Zilla::File::InMemory)
      1 perl(Dist::Zilla::Role::BeforeRelease)
      1 perl(Dist::Zilla::Role::FileGatherer)
      1 perl(Dist::Zilla::Role::FileMunger)
      1 perl(Dist::Zilla::Role::TextTemplate)
      1 perl(File::pushd) >= 0
      1 perl(Moose) >= 0.99
      1 perl(Moose::Util::TypeConstraints)
      1 perl(Sub::Exporter::ForMethods)
      1 perl(autodie) >= 2.00
      1 perl(namespace::autoclean) >= 0.09
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Plugin-CheckChangesHasContent-0.010-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Plugin::CheckChangesHasContent) = 0.010
      1 perl(Dist::Zilla::Plugin::Test::ChangesHasContent) = 0.010
      1 perl-Dist-Zilla-Plugin-CheckChangesHasContent = 0.010-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-CheckChangesHasContent*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-03-22 12:59:54 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-CheckChangesHasContent

Comment 3 Petr Pisar 2017-03-22 15:00:53 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.