+++ This bug was initially created as a clone of Bug #1433992 +++

Description of problem:
It is not possible to rebuild freeIPA in koji due to broken
CFLAGS provided by dirsrv(389-ds-base-devel)


Version-Release number of selected component (if applicable):
sh$ rpm -q 389-ds-base-devel
389-ds-base-devel-1.3.6.2-2.fc26

How reproducible:
Deterministic

Steps to Reproduce:
1. dnf install --best -y 'pkgconfig(dirsrv)'
2. pkg-config --cflags dirsrv

Actual results:
//invalid string in CFLAGS
@ldaplib_defs@ -I/dirsrv

Expected results:
//output from fedora25
-DUSE_OPENLDAP -I/usr/include/dirsrv

Additional info:
There are more unexpaded values in pkgconfig file.

sh$ cat /usr/lib64/pkgconfig/dirsrv.pc 
ldaplib=@ldaplib@

Name: dirsrv
Description: 389 Directory Server
Version: 1.3.6.2
Libs: -L${libdir}//dirsrv -lslapd
Cflags: @ldaplib_defs@ -I${includedir}//dirsrv

--- Additional comment from  on 2017-03-20 10:23:30 EDT ---

Assigning to William since he added the pkgconfig files.

--- Additional comment from wibrown on 2017-03-21 02:49:25 EDT ---

Upstream ticket:
https://pagure.io/389-ds-base/issue/49177

--- Additional comment from  on 2017-03-21 22:07:44 EDT ---

Does this build address the issues with pkgcfg?

https://koji.fedoraproject.org/koji/taskinfo?taskID=18512577

--- Additional comment from wibrown on 2017-03-22 00:38:05 EDT ---

It looks like it:

wget https://kojipkgs.fedoraproject.org//work/tasks/2578/18512578/389-ds-base-devel-1.3.6.3-2.fc26.x86_64.rpm
rpm2cpio ./389-ds-base-devel-1.3.6.3-2.fc26.x86_64.rpm| cpio -idv

cat ./usr/lib64/pkgconfig/dirsrv.pc

ldaplib=openldap

Name: dirsrv
Description: 389 Directory Server
Version: 1.3.6.3
Libs: -L${libdir}//dirsrv -lslapd
Cflags: -DUSE_OPENLDAP -I${includedir}//dirsrv

--- Additional comment from  on 2017-03-22 12:13:57 EDT ---

(In reply to wibrown from comment #4)
> It looks like it:
> 
> wget
> https://kojipkgs.fedoraproject.org//work/tasks/2578/18512578/389-ds-base-
> devel-1.3.6.3-2.fc26.x86_64.rpm
> rpm2cpio ./389-ds-base-devel-1.3.6.3-2.fc26.x86_64.rpm| cpio -idv
> 
> cat ./usr/lib64/pkgconfig/dirsrv.pc
> 
> ldaplib=openldap
> 
> Name: dirsrv
> Description: 389 Directory Server
> Version: 1.3.6.3
> Libs: -L${libdir}//dirsrv -lslapd
> Cflags: -DUSE_OPENLDAP -I${includedir}//dirsrv

Aren't the %{ var } supposed to be filled in?

--- Additional comment from Lukas Slebodnik on 2017-03-22 12:25:46 EDT ---

(In reply to mreynolds from comment #5)
> (In reply to wibrown from comment #4)
> > It looks like it:
> > 
> > wget
> > https://kojipkgs.fedoraproject.org//work/tasks/2578/18512578/389-ds-base-
> > devel-1.3.6.3-2.fc26.x86_64.rpm
> > rpm2cpio ./389-ds-base-devel-1.3.6.3-2.fc26.x86_64.rpm| cpio -idv
> > 
> > cat ./usr/lib64/pkgconfig/dirsrv.pc
> > 
> > ldaplib=openldap
> > 
> > Name: dirsrv
> > Description: 389 Directory Server
> > Version: 1.3.6.3
> > Libs: -L${libdir}//dirsrv -lslapd
> > Cflags: -DUSE_OPENLDAP -I${includedir}//dirsrv
> 
> Aren't the %{ var } supposed to be filled in?

No,
because pkgconfig  can expand them.
However they are not defined in dirsrv.pc

e.g.
  prefix=/usr/local
  exec_prefix=${prefix}
  libdir=${exec_prefix}/lib
  includedir=${prefix}/include

  Name: ipa_hbac
  Description: FreeIPA HBAC Evaluator library
  Version: 1.15.3
  Libs: -L${libdir} -lipa_hbac
  Cflags: I${includedir}/ipa_hbac
  URL: https://pagure.io/SSSD/sssd/

So there is missing in dirsrv.pc.in (and probably others as well)
  prefix=@prefix@
  exec_prefix=@exec_prefix@
  libdir=@libdir@
  includedir=@includedir@

My fault; I didn't explain it properly in upstream ticket
https://pagure.io/389-ds-base/issue/49177#comment-432430

--- Additional comment from Lukas Slebodnik on 2017-03-22 12:37:25 EDT ---

https://pagure.io/389-ds-base/issue/raw/files/82b80363857846caeeff342fca4c34dd532c218159720ce31f1216bdce912a45-0001-Ticket-49177-rpm-would-not-create-valid-pkgconfig-fi.patch

--- Additional comment from  on 2017-03-22 14:44:14 EDT ---

Fixed in upstream 389-ds-base-1.3.6.3-4