Bug 1435104 - Review Request: perl-Dist-Zilla-Role-FileWatcher - Receive notification when something changes a file's contents
Summary: Review Request: perl-Dist-Zilla-Role-FileWatcher - Receive notification when ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1435118
TreeView+ depends on / blocked
 
Reported: 2017-03-23 07:48 UTC by Petr Pisar
Modified: 2017-03-24 13:32 UTC (History)
2 users (show)

Fixed In Version: perl-Dist-Zilla-Role-FileWatcher-0.006-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-24 13:32:37 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-23 07:48:06 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Role-FileWatcher/perl-Dist-Zilla-Role-FileWatcher.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Role-FileWatcher/perl-Dist-Zilla-Role-FileWatcher-0.006-1.fc27.src.rpm
Description:
This is a role for Dist::Zilla plugins which gives you a mechanism for
detecting and acting on files changing their content. This is useful if
your plugin performs an action based on a file's content (perhaps copying
that content to another file), and then later in the build process, that
source file's content is later modified.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-24 12:28:27 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Dist-Zilla-Role-FileWatcher-0.006-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Digest::MD5)
      1 perl(Dist::Zilla) >= 4.300039
      1 perl(Dist::Zilla::Role::File::ChangeNotification)
      1 perl(Encode)
      1 perl(Moose::Role)
      1 perl(Safe::Isa)
      1 perl(namespace::autoclean)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Role-FileWatcher-0.006-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Role::File::ChangeNotification) = 0.006
      1 perl(Dist::Zilla::Role::FileWatcher) = 0.006
      1 perl-Dist-Zilla-Role-FileWatcher = 0.006-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Role-FileWatcher*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-03-24 13:18:46 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Role-FileWatcher

Comment 3 Petr Pisar 2017-03-24 13:32:37 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.