Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-CopyFilesFromBuild/perl-Dist-Zilla-Plugin-CopyFilesFromBuild.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-CopyFilesFromBuild/perl-Dist-Zilla-Plugin-CopyFilesFromBuild-0.163040-1.fc27.src.rpm Description: This Dist::Zilla plugin will automatically copy the files that you specify in dist.ini from the build directory into the distribution directory. This is so you can commit them to version control. Fedora Account System Username: ppisar
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --provides perl-Dist-Zilla-Plugin-CopyFilesFromBuild-0.163040-1.fc27.noarch.rpm | sort | uniq -c 1 perl(Dist::Zilla::Plugin::CopyFilesFromBuild) = 0.163040 1 perl-Dist-Zilla-Plugin-CopyFilesFromBuild = 0.163040-1.fc27 Binary provides are Ok. $ rpmlint ./perl-Dist-Zilla-Plugin-CopyFilesFromBuild* perl-Dist-Zilla-Plugin-CopyFilesFromBuild.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii perl-Dist-Zilla-Plugin-CopyFilesFromBuild.src: W: spelling-error %description -l en_US ini -> uni, in, ii 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok $ rpm -qp --requires perl-Dist-Zilla-Plugin-CopyFilesFromBuild-0.163040-1.fc27.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(Dist::Zilla::Role::AfterBuild) 1 perl(File::Copy) 1 perl(List::Util) >= 1.33 1 perl(Moose) 1 perl(MooseX::Has::Sugar) 1 perl(Path::Tiny) 1 perl(Set::Scalar) 1 perl(strict) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 'perl(IO::File)' is missing in build/run-requires. It is used in lib/Dist/Zilla/Plugin/CopyFilesFromBuild.pm (line 91 and 99). FIX: Please add build-require and run-require 'perl(IO::File)' Please correct 'FIX' issue. Otherwise the package looks good. Approved.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-CopyFilesFromBuild
Thank you for the review and the repository. I'm not going to add the dependency because the modules is not loaded from the package. It only calls a method from that name space. It's probably a bug in the review module that it does not "use IO::File", but requiring it on RPM level won't fix it when the modules stops being loaded transitively. I will report the mistake to the upstream.
Reported to <https://rt.cpan.org/Public/Bug/Display.html?id=120792>.