Bug 1435130 - Review Request: perl-Dist-Zilla-Plugin-CopyFilesFromRelease - Copy files from a release for SCM inclusion
Summary: Review Request: perl-Dist-Zilla-Plugin-CopyFilesFromRelease - Copy files from...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-23 08:50 UTC by Petr Pisar
Modified: 2017-03-23 14:26 UTC (History)
2 users (show)

Fixed In Version: perl-Dist-Zilla-Plugin-CopyFilesFromRelease-0.006-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-23 14:26:28 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-23 08:50:11 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-CopyFilesFromRelease/perl-Dist-Zilla-Plugin-CopyFilesFromRelease.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-CopyFilesFromRelease/perl-Dist-Zilla-Plugin-CopyFilesFromRelease-0.006-1.fc27.src.rpm
Description:
This Dist::Zilla plugin will automatically copy the files that you specify in
dist.ini from the build directory into the distribution directory. This is so
you can commit them to version control.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-23 13:28:23 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Dist-Zilla-Plugin-CopyFilesFromRelease-0.006-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Dist::Zilla::Role::AfterRelease)
      1 perl(File::Copy)
      1 perl(Moose)
      1 perl(Path::Tiny)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Plugin-CopyFilesFromRelease-0.006-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Plugin::CopyFilesFromRelease) = 0.006
      1 perl-Dist-Zilla-Plugin-CopyFilesFromRelease = 0.006-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-CopyFilesFromRelease*
perl-Dist-Zilla-Plugin-CopyFilesFromRelease.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii
perl-Dist-Zilla-Plugin-CopyFilesFromRelease.src: W: spelling-error %description -l en_US ini -> uni, in, ii
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-23 13:43:15 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-CopyFilesFromRelease

Comment 3 Petr Pisar 2017-03-23 14:26:28 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.