Bug 1435150 - Review Request: perl-Pod-Weaver-Section-Contributors - Section listing contributors
Summary: Review Request: perl-Pod-Weaver-Section-Contributors - Section listing contri...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1435155
TreeView+ depends on / blocked
 
Reported: 2017-03-23 09:35 UTC by Petr Pisar
Modified: 2017-03-23 16:29 UTC (History)
2 users (show)

Fixed In Version: perl-Pod-Weaver-Section-Contributors-0.009-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-23 16:29:42 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-23 09:35:11 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Pod-Weaver-Section-Contributors/perl-Pod-Weaver-Section-Contributors.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Pod-Weaver-Section-Contributors/perl-Pod-Weaver-Section-Contributors-0.009-1.fc27.src.rpm
Description:
This Pod::Weaver section adds a listing of the documents contributors.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-23 15:29:36 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Pod-Weaver-Section-Contributors-0.009-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(List::MoreUtils)
      1 perl(Moose)
      1 perl(Pod::Elemental::Element::Nested)
      1 perl(Pod::Elemental::Element::Pod5::Verbatim)
      1 perl(Pod::Weaver::Role::Section)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Pod-Weaver-Section-Contributors-0.009-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Pod::Weaver::Section::Contributors) = 0.009
      1 perl-Pod-Weaver-Section-Contributors = 0.009-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Pod-Weaver-Section-Contributors*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok


BuildRequires 
NOTE: No BRs for tests are needed. The tests are not executed,
      because AUTHOR_TESTING and RELEASE_TESTING are not set.

t/author-00-compile.t ..... skipped: these tests are for testing by the author
t/release-pod-coverage.t .. skipped: these tests are for release candidate testing
t/release-pod-syntax.t .... skipped: these tests are for release candidate testing
Files=3, Tests=0,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.10 cusr  0.01 csys =  0.13 CPU)
Result: NOTESTS

FIX: Please set AUTHOR_TESTING (and add run-requires to BRs) or remove BRs
     perl(File::Spec), perl(IO::Handle), perl(IPC::Open3), perl(Test::More)

Please correct 'FIX' issue.

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-03-23 16:09:54 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Pod-Weaver-Section-Contributors

Comment 3 Petr Pisar 2017-03-23 16:29:42 UTC
Thank you for the review and the repository. I removed the dependencies but I kept perl(Test::More) as it is used to skip the tests.


Note You need to log in before you can comment on or make changes to this bug.