Bug 1435248 - Review Request: perl-Version-Next - Increment module version numbers simply and correctly
Summary: Review Request: perl-Version-Next - Increment module version numbers simply a...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1435295
TreeView+ depends on / blocked
 
Reported: 2017-03-23 13:05 UTC by Petr Pisar
Modified: 2017-03-24 13:20 UTC (History)
2 users (show)

Fixed In Version: perl-Version-Next-1.000-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-24 13:20:43 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-23 13:05:28 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Version-Next/perl-Version-Next.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Version-Next/perl-Version-Next-1.000-1.fc27.src.rpm
Description:
This module provides a simple, correct way to increment a Perl module
version number. It does not attempt to guess what the original version
number author intended, it simply increments in the smallest possible
fashion. Decimals are incremented like an odometer. Dotted decimals are
incremented piece-wise and presented in a standardized way.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-24 12:19:47 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Version-Next-1.000-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Carp)
      1 perl(Sub::Exporter) >= 0
      1 perl(strict)
      1 perl(version) >= 0.81
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Version-Next-1.000-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Version::Next) = 1.000
      1 perl-Version-Next = 1.000-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Version-Next*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-03-24 13:04:21 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Version-Next

Comment 3 Petr Pisar 2017-03-24 13:20:43 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.