Bug 1435353 - Review Request: perl-Dist-Zilla-Plugin-NameFromDirectory - Guess distribution name from the current directory
Summary: Review Request: perl-Dist-Zilla-Plugin-NameFromDirectory - Guess distribution...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-23 15:22 UTC by Petr Pisar
Modified: 2017-03-29 07:23 UTC (History)
2 users (show)

Fixed In Version: perl-Dist-Zilla-Plugin-NameFromDirectory-0.04-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-29 07:23:18 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-23 15:22:24 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-NameFromDirectoryhttps://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-NameFromDirectory/perl-Dist-Zilla-Plugin-NameFromDirectory-0.04-1.fc27.src.rpm/perl-Dist-Zilla-Plugin-NameFromDirectory.spec
SRPM URL: 
Description:
This is a Dist::Zilla plugin to guess distribution name (when it's not set in
dist.ini) from the current working directory.

Fedora Account System Username: ppisar

Comment 2 Jitka Plesnikova 2017-03-28 08:44:44 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Dist-Zilla-Plugin-NameFromDirectory-0.04-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.8.0
      1 perl(Dist::Zilla) >= 4.300030
      1 perl(Dist::Zilla::Role::NameProvider)
      1 perl(Moose)
      1 perl(Path::Tiny) >= 0.053
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Plugin-NameFromDirectory-0.04-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Plugin::NameFromDirectory) = 0.04
      1 perl-Dist-Zilla-Plugin-NameFromDirectory = 0.04-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-NameFromDirectory*
perl-Dist-Zilla-Plugin-NameFromDirectory.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii
perl-Dist-Zilla-Plugin-NameFromDirectory.src: W: spelling-error %description -l en_US ini -> uni, in, ii
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 3 Gwyn Ciesla 2017-03-28 19:03:21 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-NameFromDirectory

Comment 4 Petr Pisar 2017-03-29 07:23:18 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.