Bug 1435363 - Review Request: perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile - Parse cpanfile for Dist::Zilla prerequisites
Summary: Review Request: perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile - Parse cpanfile ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-23 15:44 UTC by Petr Pisar
Modified: 2017-03-29 07:28 UTC (History)
2 users (show)

Fixed In Version: perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile-0.08-1.fc27
Clone Of:
Environment:
Last Closed: 2017-03-29 07:28:38 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-03-23 15:44:06 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile/perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile/perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile-0.08-1.fc27.src.rpm
Description:
This is is a Dist::Zilla plugin to read cpanfile to determine prerequisites
for your distribution. This does the opposite of what
Dist::Zilla::Plugin::CPANFile does, which is to create a cpanfile using the
prerequisites collected elsewhere.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-03-28 11:31:11 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile-0.08-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Dist::Zilla) >= 4.300017
      1 perl(Dist::Zilla::Role::MetaProvider)
      1 perl(Dist::Zilla::Role::PrereqSource)
      1 perl(Module::CPANfile) >= 0.903
      1 perl(Moose)
      1 perl(Try::Tiny) >= 0.1
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile-0.08-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Dist::Zilla::Plugin::Prereqs::FromCPANfile) = 0.08
      1 perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile = 0.08-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile*
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.noarch: W: spelling-error Summary(en_US) cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.noarch: W: spelling-error %description -l en_US cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.noarch: W: spelling-error %description -l en_US CPANFile -> Campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.src: W: spelling-error Summary(en_US) cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.src: W: spelling-error %description -l en_US cpanfile -> campanile
perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile.src: W: spelling-error %description -l en_US CPANFile -> Campanile
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2017-03-28 19:03:49 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Dist-Zilla-Plugin-Prereqs-FromCPANfile

Comment 3 Petr Pisar 2017-03-29 07:28:38 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.