Spec URL: https://abompard.fedorapeople.org/reviews/python-django-picklefield/python-django-picklefield.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python-django-picklefield/python-django-picklefield-0.3.2-1.fc27.src.rpm Description: Django-picklefield provides an implementation of a pickled object field. Such fields can contain any picklable objects. The implementation is taken and adopted from Django snippet #1694 by Taavi Taijala, which is in turn based on Django snippet #513 by Oliver Beattie. Fedora Account System Username: abompard There's an rpmlint error: "E: zero-length /usr/lib/python2.7/site-packages/picklefield/models.py". We can't avoid it because some older versions of Django requires this file to be present.
Taking this review.
This package failed to run through fedora-review. The %check section failed: Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.swppdB + umask 022 + cd /builddir/build/BUILD + cd django-picklefield-0.3.2 + export PYTHONPATH=src:. + PYTHONPATH=src:. + /usr/bin/python2 /usr/bin/django-admin test --settings test_settings picklefield Traceback (most recent call last): File "/usr/bin/django-admin", line 2, in <module> from django.core import management File "/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line 13, in <module> from django.core.management.base import ( File "/usr/lib/python2.7/site-packages/django/core/management/base.py", line 17, in <module> from django.db.migrations.exceptions import MigrationSchemaMissing File "/usr/lib/python2.7/site-packages/django/db/migrations/__init__.py", line 2, in <module> from .operations import * # NOQA File "/usr/lib/python2.7/site-packages/django/db/migrations/operations/__init__.py", line 1, in <module> from .fields import AddField, AlterField, RemoveField, RenameField File "/usr/lib/python2.7/site-packages/django/db/migrations/operations/fields.py", line 3, in <module> from django.db.models.fields import NOT_PROVIDED File "/usr/lib/python2.7/site-packages/django/db/models/__init__.py", line 3, in <module> from django.db.models.aggregates import * # NOQA File "/usr/lib/python2.7/site-packages/django/db/models/aggregates.py", line 5, in <module> from django.db.models.expressions import Func, Star File "/usr/lib/python2.7/site-packages/django/db/models/expressions.py", line 5, in <module> from django.db.backends import utils as backend_utils File "/usr/lib/python2.7/site-packages/django/db/backends/utils.py", line 12, in <module> from django.utils.timezone import utc File "/usr/lib/python2.7/site-packages/django/utils/timezone.py", line 8, in <module> import pytz ImportError: No module named pytz error: Bad exit status from /var/tmp/rpm-tmp.swppdB (%check) Bad exit status from /var/tmp/rpm-tmp.swppdB (%check) It looks like the failure is caused by python2-django not pulling in python2-pytz. The same issue likely exists for python3-django (with python3-pytz).
The python-django package has been fixed in Rawhide only, so I'll just add pytz in the dependencies for now. Spec URL: https://abompard.fedorapeople.org/reviews/python-django-picklefield/python-django-picklefield.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python-django-picklefield/python-django-picklefield-0.3.2-1.fc27.src.rpm
Sorry, wrong SRPM URL. Spec URL: https://abompard.fedorapeople.org/reviews/python-django-picklefield/python-django-picklefield.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python-django-picklefield/python-django-picklefield-0.3.2-1.el7.centos.src.rpm
So, apparently, this package existed before and was retired. I'm going to treat this an unretirement request, then, and still proceed with the review.
Review notes: - Follows Python packaging guidelines - Follows extended guidelines for EPEL - Builds and installs - No rpmlint issues - No fedora-review issues PACKAGE APPROVED.
Oh dear, there were two parallel reviews going on for python-django-picklefield...
(In reply to Neal Gompa from comment #7) > Oh dear, there were two parallel reviews going on for > python-django-picklefield... Thanks for info, this is unlucky. Could Igor and Aurelien agree on further steps? I.e. who will maintain it?
It's worth to point out that Igor's request was filled first.
It's really up to Aurelien and Igor. This is a dependency for the Mailman 3 suite, which is why Aurelian was packaging it.
*** This bug has been marked as a duplicate of bug 1370644 ***