Bug 1435948 - FTBFS: Cassandra fails to (re)build generated thrift files from source
Summary: FTBFS: Cassandra fails to (re)build generated thrift files from source
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cassandra
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tomas Repik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-26 04:16 UTC by Christopher Tubbs
Modified: 2017-04-18 19:57 UTC (History)
1 user (show)

Fixed In Version: cassandra-3.9-8.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-18 19:57:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Force thrift files to be generated during the build (1.50 KB, patch)
2017-03-26 04:16 UTC, Christopher Tubbs
no flags Details | Diff

Description Christopher Tubbs 2017-03-26 04:16:49 UTC
Created attachment 1266494 [details]
Force thrift files to be generated during the build

Description of problem:

After updating thrift to version 0.10.0, Cassandra fails to build from source in F26 and rawhide, due to an API change in libthrift.jar affecting compatibility with  thrift generated java files from previous versions.

The cassandra upstream appears to version-control the thrift generated source files, and the corresponding Fedora package does not rebuild them during packaging like it should.

I've attached a patch which I believe correctly triggers a rebuild of the generated thrift files by deleting the old ones and including the `gen-thrift-java` ant target.

However, when I was testing this, I noticed that ant produced messages indicating it was downloading files from Maven Central during the build. This might be a misleading message, and it may or may not be related to adding the gen-thrift-java target to the ant build. This should be verified and corrected by the package maintainers, since Fedora builds should work offline.

I'm not proficient with ant, but have begun learning it, and am willing to provide assistance getting things working with the latest thrift.

Comment 1 Tomas Repik 2017-03-27 05:47:33 UTC
Thanks for your initiative, I'm currently working on back-porting a patch from upstream that completely removes thrift as a dependency. I think this is the way to go, as the thrift interface is deprecated for a long time and will be gone in the next major version release. I want to make this change before cassandra becomes supported in a stable release of fedora.

Comment 2 Fedora Update System 2017-03-29 08:09:29 UTC
cassandra-3.9-7.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c33dfdc0a7

Comment 3 Fedora Update System 2017-03-29 17:50:12 UTC
cassandra-3.9-7.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c33dfdc0a7

Comment 4 Fedora Update System 2017-04-05 06:57:02 UTC
cassandra-3.9-8.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c33dfdc0a7

Comment 5 Fedora Update System 2017-04-05 21:53:41 UTC
cassandra-3.9-8.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c33dfdc0a7

Comment 6 Fedora Update System 2017-04-18 19:57:32 UTC
cassandra-3.9-8.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.