Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1435982 - RabbitMQ resource agent does not form a cluster when running on pacemaker remote nodes
RabbitMQ resource agent does not form a cluster when running on pacemaker rem...
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: resource-agents (Show other bugs)
7.3
Unspecified Unspecified
urgent Severity urgent
: pre-dev-freeze
: 7.4
Assigned To: Peter Lemenkov
Udi Shkalim
: ZStream
Depends On: 1448646
Blocks: 1437122
  Show dependency treegraph
 
Reported: 2017-03-26 08:04 EDT by Udi Shkalim
Modified: 2017-08-01 10:57 EDT (History)
13 users (show)

See Also:
Fixed In Version: resource-agents-3.9.5-105.el7
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1437122 (view as bug list)
Environment:
Last Closed: 2017-08-01 10:57:40 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
undercloud sosreport (17.74 MB, application/x-xz)
2017-05-25 10:42 EDT, Udi Shkalim
no flags Details
messaging sosreports (8.88 MB, application/x-xz)
2017-05-25 10:45 EDT, Udi Shkalim
no flags Details


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:1844 normal SHIPPED_LIVE resource-agents bug fix and enhancement update 2017-08-01 13:49:20 EDT

  None (edit)
Description Udi Shkalim 2017-03-26 08:04:10 EDT
Description of problem:
When deploying a setup using HA composable role where the rabbitmq node is running on a pacemaker remote service, the rabbit nodes are not forming a cluster

Version-Release number of selected component (if applicable):
resource-agents-3.9.5-82.el7_3.6.x86_64

rabbitmq-server-3.6.5-1.el7ost.noarch


pacemaker-cluster-libs-1.1.15-11.el7_3.4.x86_64
pacemaker-remote-1.1.15-11.el7_3.4.x86_64
pacemaker-cli-1.1.15-11.el7_3.4.x86_64
pacemaker-1.1.15-11.el7_3.4.x86_64
puppet-pacemaker-0.5.0-1.el7ost.noarch
pacemaker-libs-1.1.15-11.el7_3.4.x86_64

openstack-tripleo-heat-templates-6.0.0-0.20170307170102.3134785.0rc2.el7ost.noarch

How reproducible:


Steps to Reproduce:
1. Deploy Composalble role of rabbitmq with pacemaker remote
2.
3.

Actual results:
rabbit is not creating a cluster

Expected results:
rabbit cluster is up and running between all rabbit nodes

Additional info:
Comment 3 Michele Baldessari 2017-03-27 06:14:25 EDT
Thanks to Damien for his big help on this!

So the reason the cluster is not forming properly on the remote node is that it never gets the list of all the nodes. The culprit is this line in the resource agent:
rmq_join_list()
{
    cibadmin -Q --xpath "//node_state[@crmd='online']//nvpair[@name='$RMQ_CRM_ATTR_COOKIE']" | grep "$RMQ_CRM_ATTR_COOKIE" | sed -n -e "s/^.*value=.\(.*\)\".*$/\1/p"
}

The above is supposed to collect all the nodes which wrote their name in attrd. The problem is that on remote nodes "crmd=online" is never true so the list is empty and so each node just starts on its own.

By changing the function to something like the following:
rmq_join_list()
{
        local join_list=$(cibadmin -Q --xpath "//node_state[@crmd='online']//nvpair[@name='$RMQ_CRM_ATTR_COOKIE']" | grep "$RMQ_CRM_ATTR_COOKIE" | sed -n -e "s/^.*value=.\(.*\)\".*$/\1/p")
        # If join_list is empty we want to check if there are any remote nodes
        # where rabbitmq is allowed to run (i.e. nodes without the crmd=online
        if [ -z "$join_list" ]; then
                # Get all the nodes written in the ATTR_COOKIE no matter if
                # they are online or not
                local remote_join_list=$(cibadmin -Q --xpath "//node_state//nvpair[@name='$RMQ_CRM_ATTR_COOKIE']" | grep "$RMQ_CRM_ATTR_COOKIE" | sed -n -e "s/^.*value=.\(.*\)\".*$/\1/p")
                # here we basically need to filter the nodes found above
                # and only use the nodes that have online=true and standby=false
                # basically we are mimicking crmd=online but for remotes
                local filter=$(crm_mon -r --as-xml | xmllint --format --xpath "//nodes//node[@online='true' and @standby='false']/@name" - | xargs -n1 echo | awk -F= '/rabbit/ {print "-e "
$2}')
                join_list="$(echo $remote_join_list | grep $filter)"
        fi
        echo $join_list
}


We were able to get a working cluster. Maybe we can get something a bit simpler than the above. Damien and I tried to mimick the crmd=online test for remotes. We did it because it was explicitly added for normal nodes via https://github.com/ClusterLabs/resource-agents/commit/ddb8e97e2860a3d375e9a422d48a0b9e0830416d 

Fabio, to your question: yes this is a rabbitmq resource agent issue on pacemaker remote only.

Am reassigning to the RA component
Comment 6 Oyvind Albrigtsen 2017-03-29 07:19:51 EDT
Link to patch: https://github.com/ClusterLabs/resource-agents/pull/959
Comment 9 Oyvind Albrigtsen 2017-04-04 06:53:14 EDT
New build with /rabbit/ removed from the awk-line.
Comment 11 Udi Shkalim 2017-05-25 10:42 EDT
Created attachment 1282298 [details]
undercloud sosreport
Comment 12 Udi Shkalim 2017-05-25 10:45 EDT
Created attachment 1282299 [details]
messaging sosreports
Comment 13 Udi Shkalim 2017-05-25 10:45:58 EDT
Overcloud failed:

Error: unable to push cib\nCall cib_apply_diff failed (-205): Update was older than existing configuration\n\n\u001b[1;31mError: pcs -f /var/lib/pacemaker/cib/puppet-cib-backup20170525-14352-79425q create failed: Error: unable to create resource/fence device 'messaging-0', 'messaging-0' already exists on this system\u001b[0m\n\u001b[1;31mError: /Stage[main]/Tripleo::Profile::Base::Pacemaker/Pacemaker::Resource::Remote[messaging-0]/Pcmk_resource[messaging-0]/ensure: change from absent to present failed: pcs -f /var/lib/pacemaker/cib/puppet-cib-backup20170525-14352-79425q create failed: Error: unable to create resource/fence device 'messaging-0', 'messaging-0' already exists on this system\u001b[0m\n",

sosreports attached.
Comment 18 Marian Krcmarik 2017-06-23 10:02:50 EDT
I am switching to VERIFIED.
First of all we have the patch in 7.3.z so we need to include that in 7.4 anyway + the problem is that the race (Bug 1448646) prevents to verify this bug easily but I applied the patch from that bug and was able to verify this bug which was already verified on 7.3.z.

Used build:
Comment 19 errata-xmlrpc 2017-08-01 10:57:40 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1844

Note You need to log in before you can comment on or make changes to this bug.