Bug 1436010 (php-google-apiclient1) - Review Request: php-google-apiclient1 - Client library for Google APIs (version 1)
Summary: Review Request: php-google-apiclient1 - Client library for Google APIs (versi...
Keywords:
Status: CLOSED ERRATA
Alias: php-google-apiclient1
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1386152 1438295
TreeView+ depends on / blocked
 
Reported: 2017-03-26 17:10 UTC by Shawn Iwinski
Modified: 2017-04-09 05:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-09 05:58:49 UTC
Type: ---
Embargoed:
fedora: fedora-review+


Attachments (Terms of Use)
phpci.log (510.44 KB, text/plain)
2017-03-27 05:39 UTC, Remi Collet
no flags Details
review.txt (7.82 KB, text/plain)
2017-03-27 05:40 UTC, Remi Collet
no flags Details

Description Shawn Iwinski 2017-03-26 17:10:34 UTC
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/3b6f297fd084cfd9ceaaf35fa91fd2a2b27078d5/php-google-apiclient1/php-google-apiclient1.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-google-apiclient1-1.1.7-1.fc25.src.rpm

Description:
Google APIs Client Library for PHP provides access to many Google APIs.
It is designed for PHP client-application developers and offers simple,
flexible, powerful API access.

Fedora Account System Username: siwinski

Comment 1 Remi Collet 2017-03-27 05:39:52 UTC
Created attachment 1266549 [details]
phpci.log

phpCompatInfo version 5.0.5 DB version 1.19.0 built Mar 17 2017 06:44:54 CET

Comment 2 Remi Collet 2017-03-27 05:40:18 UTC
Created attachment 1266550 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1436010
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api

Comment 3 Remi Collet 2017-03-27 05:40:53 UTC
[x]: Package does not generate any conflict.
	Conflicts present for safe upgrade path

[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
	You could have kept epoch = 2 (raising release to 3)
	BTW, this means you will also have to set epoch to 3 in v2 package
	Hopefuly, dependent packages should only use composer dep.

	=> Missing "Obsoletes" in the examples sub-package

[x]: Latest version is packaged.
	Lastest compatible v1, by design


Single blocker, missing obsoletes.

Comment 4 Shawn Iwinski 2017-03-28 11:51:00 UTC
(In reply to Remi Collet from comment #3)
> [x]: Package does not generate any conflict.
> 	Conflicts present for safe upgrade path
> 
> [-]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
> 	You could have kept epoch = 2 (raising release to 3)
> 	BTW, this means you will also have to set epoch to 3 in v2 package
> 	Hopefuly, dependent packages should only use composer dep.

I was originally going for release 1 on the new pkg, but to be honest, I don't know why :/  I took your advise and bumped the release (4, not 3) and kept epoch 2 in the obsoletes/provides.



> 	=> Missing "Obsoletes" in the examples sub-package

Added



> [x]: Latest version is packaged.
> 	Lastest compatible v1, by design
> 
> 
> Single blocker, missing obsoletes.



Spec URL: https://raw.githubusercontent.com/siwinski/rpms/8407132e85687b5f7765244b0c42d185bc6cf3c1/php-google-apiclient1/php-google-apiclient1.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-google-apiclient1-1.1.7-4.fc25.src.rpm

Comment 5 Remi Collet 2017-03-28 12:01:35 UTC
+# Package rename (php-google-apiclient => php-google-apiclient1)
+Obsoletes:     php-google-apiclient-examples < 2:1.1.7-4
+Provides:      php-google-apiclient-examples = 2:%{version}-%{release}
+

 
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.


No more blocker

== APPROVED ==

Comment 6 Gwyn Ciesla 2017-03-28 19:02:47 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-google-apiclient1

Comment 7 Fedora Update System 2017-04-02 22:17:17 UTC
php-google-apiclient1-1.1.7-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-aecefe7602

Comment 8 Fedora Update System 2017-04-04 01:52:40 UTC
php-google-apiclient1-1.1.7-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-aecefe7602

Comment 9 Fedora Update System 2017-04-09 05:58:49 UTC
php-google-apiclient1-1.1.7-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.