Spec URL: https://cheeselee.fedorapeople.org/ocfs2-tools.spec SRPM URL: https://cheeselee.fedorapeople.org/ocfs2-tools-1.8.5-1.fc24.src.rpm Description: Programs to manage the OCFS2 cluster file system, including mkfs.ocfs2, tunefs.ocfs2 and fsck.ocfs2. OCFS2 is a general purpose extent based shared disk cluster file system. It supports 64 bit inode numbers, and has automatically extending metadata groups which may also make it attractive for non-clustered use. OCFS2 leverages some well tested kernel technologies, such as JBD - the same journaling subsystem in use by ext3. Fedora Account System Username: cheeselee
Fortified build failed on f26.
Hello, - You must install COPYING in %license: %files %doc README.O2CB COPYING CREDITS MAINTAINERS %doc documentation/users_guide.txt %license COPYING - make install DESTDIR=%{buildroot} ⇒ %make_install - For clarity, please only use one BR and R per line - Group: is not used in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - Build fails with: gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -pipe -I../include -Iinclude -DVERSION=\"1.8.5\" -MD -MP -MF ./.pass4.d -o pass4.o -c pass4.c In file included from /usr/include/string.h:431:0, from ../include/ocfs2/ocfs2.h:41, from pass4.c:32: include/strings.h:37:1: error: unknown type name 'errcode_t'; did you mean 'mode_t'? errcode_t o2fsck_strings_insert(o2fsck_strings *strings, char *string, ^~~~~~~~~ mode_t make[1]: Leaving directory '/builddir/build/BUILD/ocfs2-tools-ocfs2-tools-1.8.5/fsck.ocfs2
Spec URL: https://cheeselee.fedorapeople.org/ocfs2-tools.spec SRPM URL: https://cheeselee.fedorapeople.org/ocfs2-tools-1.8.5-2.fc28.src.rpm Re-open for review. Changes: - Fix build for f28 - Move COPYING to %%license - Use %%make_install - one BR or R per line
- Group: is not needed - Patch the incorrect FSF address and notify upstream about it: ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/__init__.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/about.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/bosa.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/classlabel.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/confdefs.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/console.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/format.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/fsck.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/fstab.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/fswidgets.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/general.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/guiutil.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/ipwidget.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/ls.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/menu.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/mount.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/nodeconfig.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/o2cb_ctl.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/partitionview.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/process.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/pushconfig.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/terminal.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/toolbar.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/tune.py ocfs2-tools-devel.x86_64: E: incorrect-fsf-address /usr/include/ocfs2/kernel-rbtree.h ocfs2-tools-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/ocfs2-tools-1.8.5-2.fc28.x86_64/include/ocfs2/kernel-rbtree.h ocfs2-tools-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/ocfs2-tools-1.8.5-2.fc28.x86_64/libocfs2/kernel-rbtree.c grep -rl '59 Temple Place, Suite 330, Boston, MA 02111-1307 USA' * | xargs -i@ sed -i 's/59 Temple Place, Suite 330, Boston, MA 02111-1307 USA/51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA./g' @ grep -rl '59 Temple Place - Suite 330, Boston, MA 021110-1307, USA.' * | xargs -i@ sed -i 's/59 Temple Place - Suite 330, Boston, MA 021110-1307, USA./51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA./g' @ grep -rl '59 Temple Place - Suite 330,' * | xargs -i@ sed -i 's/59 Temple Place - Suite 330/51 Franklin Street, Fifth Floor/; s/02111-1307/02110-1301/g' @ - udev-rule-in-etc: A udev rule has been packaged in /etc/udev/rules.d. These rules should be installed in the system rules dir instead. ocfs2-tools.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/51-ocfs2.rules i.e. install the file in %{_udevrulesdir} (aka /usr/lib/udev/rules.d) - You're missing %{?_isa} in your Requires for console and devel: Requires: %{name}%{?_isa} = %{version}-%{release} - Package contains BR: python2-devel or python3-devel You must BR python2-devel or python3-devel instead of python-devel Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2)", "LGPL (v2 or later)", "GPL (v2) (with incorrect FSF address)", "*No copyright* GPL (v2)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "GPL (v2)". 223 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ocfs2-tools/review- ocfs2-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/udev, /etc/udev/rules.d [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: ocfs2-tools-devel. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocfs2console , ocfs2-tools-devel [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocfs2-tools-1.8.5-2.fc28.x86_64.rpm ocfs2console-1.8.5-2.fc28.x86_64.rpm ocfs2-tools-devel-1.8.5-2.fc28.x86_64.rpm ocfs2-tools-debuginfo-1.8.5-2.fc28.x86_64.rpm ocfs2-tools-debugsource-1.8.5-2.fc28.x86_64.rpm ocfs2-tools-1.8.5-2.fc28.src.rpm ocfs2-tools.x86_64: W: spelling-error %description -l en_US mkfs -> mks ocfs2-tools.x86_64: W: spelling-error %description -l en_US tunefs -> tunes, tuners, tune's ocfs2-tools.x86_64: W: spelling-error %description -l en_US fsck -> Schick ocfs2-tools.x86_64: W: spelling-error %description -l en_US inode -> node, anode, i node ocfs2-tools.x86_64: W: spelling-error %description -l en_US journaling -> journalism, journalist, journal ocfs2-tools.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/51-ocfs2.rules ocfs2-tools.x86_64: E: incorrect-fsf-address /usr/share/licenses/ocfs2-tools/COPYING ocfs2-tools.x86_64: W: no-manual-page-for-binary o2cb.init ocfs2-tools.x86_64: W: no-manual-page-for-binary ocfs2.init ocfs2-tools.x86_64: W: empty-%postun ocfs2console.x86_64: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end ocfs2console.x86_64: W: spelling-error %description -l en_US gui -> GUI, goo, gun ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/__init__.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/about.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/bosa.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/classlabel.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/confdefs.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/console.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/format.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/fsck.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/fstab.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/fswidgets.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/general.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/guiutil.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/ipwidget.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/ls.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/menu.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/mount.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/nodeconfig.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/o2cb_ctl.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/partitionview.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/process.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/pushconfig.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/terminal.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/toolbar.py ocfs2console.x86_64: E: incorrect-fsf-address /usr/lib64/python2.7/site-packages/ocfs2interface/tune.py ocfs2-tools-devel.x86_64: W: no-documentation ocfs2-tools-devel.x86_64: E: incorrect-fsf-address /usr/include/ocfs2/kernel-rbtree.h ocfs2-tools-debuginfo.x86_64: E: useless-provides debuginfo(build-id) ocfs2-tools-debugsource.x86_64: W: no-documentation ocfs2-tools-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/ocfs2-tools-1.8.5-2.fc28.x86_64/include/ocfs2/kernel-rbtree.h ocfs2-tools-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/ocfs2-tools-1.8.5-2.fc28.x86_64/libocfs2/kernel-rbtree.c ocfs2-tools.src: W: spelling-error %description -l en_US mkfs -> mks ocfs2-tools.src: W: spelling-error %description -l en_US tunefs -> tunes, tuners, tune's ocfs2-tools.src: W: spelling-error %description -l en_US fsck -> Schick ocfs2-tools.src: W: spelling-error %description -l en_US inode -> node, anode, i node ocfs2-tools.src: W: spelling-error %description -l en_US journaling -> journalism, journalist, journal 6 packages and 0 specfiles checked; 29 errors, 18 warnings.
Spec URL: https://cheeselee.fedorapeople.org/ocfs2-tools.spec SRPM URL: https://cheeselee.fedorapeople.org/ocfs2-tools-1.8.5-3.fc28.src.rpm - Remove Group tags - Fix FSF address in files - Move udev rule to %%{_udevrulesdir} - Add needed %%{?_isa} - BR python2-devel
All ok, package approved.